Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Richard Henderson
On 11/03/2011 01:32 PM, Richard Henderson wrote: > Indeed. The skeleton for libitm was libgomp. And libgomp does do > fortran stuff, which leads directly to the two errant fortran > references spotted by Joseph. > > Will fix. Here's the fix for both gfortran references. Committed to the branch.

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Aldy Hernandez
On 11/03/11 17:36, Jakub Jelinek wrote: On Thu, Nov 03, 2011 at 05:26:43PM -0500, Aldy Hernandez wrote: I'm going to assume the tests themselves are good. It'd be nice if they all stated what they were testing, but I don't consider that a requirement. If the tests were written independently ra

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2011 at 05:26:43PM -0500, Aldy Hernandez wrote: > >I'm going to assume the tests themselves are good. It'd be nice if > >they all stated what they were testing, but I don't consider that a > >requirement. If the tests were written independently rather than > >extracted from anothe

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Aldy Hernandez
On 11/03/11 15:33, Jeff Law wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 11:44, Aldy Hernandez wrote: These are all new files, thus require no ChangeLog entries (for the tests themselves anyhow). However, I will post a separate ChangeLog for the entire libitm. Note copyrig

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 11:44, Aldy Hernandez wrote: > These are all new files, thus require no ChangeLog entries (for > the tests themselves anyhow). However, I will post a separate > ChangeLog for the entire libitm. Note copyright dates... Make sure they're no

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Richard Henderson
On 11/03/2011 01:21 PM, Richard Henderson wrote: > On 11/03/2011 01:08 PM, Aldy Hernandez wrote: >> On 11/03/11 15:00, Joseph S. Myers wrote: >>> Why are you using gfortran-dg.exp and gfortran-dg-runtest when as far as I >>> can tell there is nothing Fortran-related in these tests? >>> >> >> Richar

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Richard Henderson
On 11/03/2011 01:08 PM, Aldy Hernandez wrote: > On 11/03/11 15:00, Joseph S. Myers wrote: >> Why are you using gfortran-dg.exp and gfortran-dg-runtest when as far as I >> can tell there is nothing Fortran-related in these tests? >> > > Richard? Um... cut-and-paste from the wrong original file?

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Aldy Hernandez
On 11/03/11 15:00, Joseph S. Myers wrote: Why are you using gfortran-dg.exp and gfortran-dg-runtest when as far as I can tell there is nothing Fortran-related in these tests? Richard?

Re: [patch] 1/n: trans-mem: libitm runtime tests

2011-11-03 Thread Joseph S. Myers
Why are you using gfortran-dg.exp and gfortran-dg-runtest when as far as I can tell there is nothing Fortran-related in these tests? -- Joseph S. Myers jos...@codesourcery.com