Re: [patch,avr] Disable CRC lookup tables

2024-12-07 Thread Georg-Johann Lay
Am 07.12.24 um 02:03 schrieb Oleg Endo: On Fri, 2024-12-06 at 16:51 +0100, Georg-Johann Lay wrote: The CRC tables ARE put into .rodata, not into .data. The correct question is: Why is avr putting .rodata into RAM? Suppose the following C code: char read_c (const char *p) { return p[1]

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Oleg Endo
On Fri, 2024-12-06 at 16:51 +0100, Georg-Johann Lay wrote: > > The CRC tables ARE put into .rodata, not into .data. > > The correct question is: Why is avr putting .rodata into RAM? > > Suppose the following C code: > > char read_c (const char *p) > { > return p[1]; > } > > Where p may

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Georg-Johann Lay
Am 06.12.24 um 15:50 schrieb Oleg Endo: On Fri, 2024-12-06 at 06:32 -0700, Jeff Law wrote: On 12/6/24 5:23 AM, Sam James wrote: Georg-Johann Lay writes: This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to CC the pass au

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Oleg Endo
On Fri, 2024-12-06 at 06:32 -0700, Jeff Law wrote: > > On 12/6/24 5:23 AM, Sam James wrote: > > Georg-Johann Lay writes: > > > > > This patch disables CRC lookup tables which consume quite some RAM. > > > > Given that -foptimize-crc is new, it may be useful to CC the pass > > authors in case th

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Georg-Johann Lay
Am 06.12.24 um 14:53 schrieb Richard Biener: On Fri, Dec 6, 2024 at 2:17 PM Georg-Johann Lay wrote: Am 06.12.24 um 13:23 schrieb Sam James: Georg-Johann Lay writes: This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to C

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Sam James
Georg-Johann Lay writes: > Am 06.12.24 um 13:23 schrieb Sam James: >> Georg-Johann Lay writes: >> >>> This patch disables CRC lookup tables which consume quite some RAM. >> Given that -foptimize-crc is new, it may be useful to CC the pass >> authors in case they have input. > > CCing Mariam Aru

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Richard Biener
On Fri, Dec 6, 2024 at 2:17 PM Georg-Johann Lay wrote: > > Am 06.12.24 um 13:23 schrieb Sam James: > > Georg-Johann Lay writes: > > > >> This patch disables CRC lookup tables which consume quite some RAM. > > > > Given that -foptimize-crc is new, it may be useful to CC the pass > > authors in cas

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Jeff Law
On 12/6/24 5:23 AM, Sam James wrote: Georg-Johann Lay writes: This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to CC the pass authors in case they have input. I think this is trivially OK for the AVR. The bigger questi

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Georg-Johann Lay
Am 06.12.24 um 13:23 schrieb Sam James: Georg-Johann Lay writes: This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to CC the pass authors in case they have input. CCing Mariam Arutunian Ok for trunk? Johann The probl

Re: [patch,avr] Disable CRC lookup tables

2024-12-06 Thread Sam James
Georg-Johann Lay writes: > This patch disables CRC lookup tables which consume quite some RAM. Given that -foptimize-crc is new, it may be useful to CC the pass authors in case they have input. > > Ok for trunk? > > Johann