Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-24 Thread Thomas König
Hi Steve, OK. Thanks for taking on this task. Committed (r274902). Thanks for the review! As to the open question about how to handle this check, I would create -fallow-argument-mismatch (or whatever option name you like). gfortran issues an error if a mismatch is detected. -fallow-... wo

Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-24 Thread Steve Kargl
On Tue, Aug 20, 2019 at 10:32:37PM +0200, Thomas König wrote: > > 2019-08-20 Thomas Koenig > > PR fortran/91390 > * frontend-passes.c (check_externals_procedure): New > function. If a procedure is not in the translation unit, create > an "interface" for it, including it

Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-22 Thread Steve Kargl
On Thu, Aug 22, 2019 at 08:50:20PM +0200, Thomas Koenig wrote: > Am 20.08.19 um 22:32 schrieb Thomas König: > > > here is the next installment of checking for mismatched calls, > > this time for mismatching CALLs. > > The reorganization of the code also means that > https://gcc.gnu.org/bugzilla/s

Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-22 Thread Thomas Koenig
Am 20.08.19 um 22:32 schrieb Thomas König: here is the next installment of checking for mismatched calls, this time for mismatching CALLs. The reorganization of the code also means that https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91519 (a rejects-valid regression) is fixed by this patch. So,