Re: [libstdc++/71500] make back reference work with icase

2017-09-19 Thread Jonathan Wakely
On 19/09/17 15:38 +0100, Jonathan Wakely wrote: On 18/09/17 16:54 -0700, Tim Shen wrote: On Mon, Sep 18, 2017 at 4:01 PM, Jonathan Wakely wrote: On 18/09/17 10:58 -0700, Tim Shen via libstdc++ wrote: On Mon, Sep 18, 2017 at 10:26 AM, Jonathan Wakely wrote: We need to rewrite this to check

Re: [libstdc++/71500] make back reference work with icase

2017-09-19 Thread Jonathan Wakely
The failures that need to be fixed can be seen at https://gcc.gnu.org/ml/gcc-testresults/2017-09/msg01633.html

Re: [libstdc++/71500] make back reference work with icase

2017-09-19 Thread Jonathan Wakely
On 18/09/17 16:54 -0700, Tim Shen wrote: On Mon, Sep 18, 2017 at 4:01 PM, Jonathan Wakely wrote: On 18/09/17 10:58 -0700, Tim Shen via libstdc++ wrote: On Mon, Sep 18, 2017 at 10:26 AM, Jonathan Wakely wrote: We need to rewrite this to check the lengths are equal first, and then call the 3

Re: [libstdc++/71500] make back reference work with icase

2017-09-18 Thread Tim Shen via gcc-patches
On Mon, Sep 18, 2017 at 4:01 PM, Jonathan Wakely wrote: > On 18/09/17 10:58 -0700, Tim Shen via libstdc++ wrote: >> >> On Mon, Sep 18, 2017 at 10:26 AM, Jonathan Wakely >> wrote: We need to rewrite this to check the lengths are equal first, and then call the 3-argument version of s

Re: [libstdc++/71500] make back reference work with icase

2017-09-18 Thread Jonathan Wakely
On 18/09/17 10:58 -0700, Tim Shen via libstdc++ wrote: On Mon, Sep 18, 2017 at 10:26 AM, Jonathan Wakely wrote: We need to rewrite this to check the lengths are equal first, and then call the 3-argument version of std::equal. Alternatively, we could move the implementation of the C++14 std::eq

Re: [libstdc++/71500] make back reference work with icase

2017-09-18 Thread Tim Shen via gcc-patches
On Mon, Sep 18, 2017 at 10:26 AM, Jonathan Wakely wrote: >> We need to rewrite this to check the lengths are equal first, and then >> call the 3-argument version of std::equal. >> >> Alternatively, we could move the implementation of the C++14 >> std::equal overloads to __equal and make that avail

Re: [libstdc++/71500] make back reference work with icase

2017-09-18 Thread Jonathan Wakely
On 15/09/17 16:39 +0100, Jonathan Wakely wrote: On 04/09/17 03:31 -0700, Tim Shen via libstdc++ wrote: This fixes the follow-up comments in 71500. Back-reference matching is different from other matching, as the content the back-reference refers to is at "run-time", aka during regex_match(), no

Re: [libstdc++/71500] make back reference work with icase

2017-09-15 Thread Jonathan Wakely
On 04/09/17 03:31 -0700, Tim Shen via libstdc++ wrote: This fixes the follow-up comments in 71500. Back-reference matching is different from other matching, as the content the back-reference refers to is at "run-time", aka during regex_match(), not regex() compilation. For compilation we do hav

Re: [libstdc++/71500] make back reference work with icase

2017-09-08 Thread Jonathan Wakely
On 04/09/17 03:31 -0700, Tim Shen via libstdc++ wrote: This fixes the follow-up comments in 71500. Back-reference matching is different from other matching, as the content the back-reference refers to is at "run-time", aka during regex_match(), not regex() compilation. For compilation we do hav