Re: [jit] Fix state issue in gcse.c

2014-04-25 Thread Steven Bosscher
On Fri, Apr 25, 2014 at 9:48 PM, David Malcolm wrote: > Thanks; your patch does indeed fix the issue: with it, I no longer need > the band-aid from my patch to be able to run the jit testsuite with full > optimization. Good. In the mean time I tested the patch, and found a typo: + if (icode != 0

Re: [jit] Fix state issue in gcse.c

2014-04-25 Thread David Malcolm
On Sat, 2014-04-19 at 15:55 +0200, Steven Bosscher wrote: > On Sat, Apr 19, 2014 at 3:24 PM, Steven Bosscher wrote: > > On Tue, Mar 11, 2014 at 8:00 PM, David Malcolm wrote: > >> Investigation revealed the issue to be a CFG from the previous compile > >> being kept alive by this GC root in gcse.c:

Re: [jit] Fix state issue in gcse.c

2014-04-19 Thread Steven Bosscher
On Sat, Apr 19, 2014 at 3:24 PM, Steven Bosscher wrote: > On Tue, Mar 11, 2014 at 8:00 PM, David Malcolm wrote: >> Investigation revealed the issue to be a CFG from the previous compile >> being kept alive by this GC root in gcse.c: >> static GTY(()) rtx test_insn; >> >> This wouldn't it

Re: [jit] Fix state issue in gcse.c

2014-04-19 Thread Steven Bosscher
On Tue, Mar 11, 2014 at 8:00 PM, David Malcolm wrote: > Investigation revealed the issue to be a CFG from the previous compile > being kept alive by this GC root in gcse.c: > static GTY(()) rtx test_insn; > > This wouldn't it itself be an issue, but one (or more) of the edges had: But th