Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-07-03 Thread Michael Matz
Hi, On Mon, 2 Jul 2012, Tobias Grosser wrote: > > Yeah. If my above understanding is correct the path is clear. > > I believe it is. It somewhat works. It has problems in those cases where there are dependencies between different input dimensions in the scattering, which happens for strip-m

Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-07-02 Thread Tobias Grosser
On 07/02/2012 01:32 PM, Michael Matz wrote: +++ b/gcc/graphite.c @@ -253,6 +253,8 @@ graphite_finalize (bool need_cfg_cleanup_p) print_loops (dump_file, 3); } +isl_ctx *the_isl_ctx; Why are you creating a global ctx here? For the printer, before I was aware of the fact that of cour

Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-07-02 Thread Tobias Grosser
On 07/02/2012 01:32 PM, Michael Matz wrote: Hi Tobi, On Fri, 29 Jun 2012, Tobias Grosser wrote: +static isl_constraint * +build_linearized_memory_access (isl_map *map, poly_dr_p pdr) +{ +} The function itself looks correct. However, I would personally have returned an isl_map instead of an i

Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-07-02 Thread Michael Matz
Hi Tobi, On Fri, 29 Jun 2012, Tobias Grosser wrote: > > +static isl_constraint * > > +build_linearized_memory_access (isl_map *map, poly_dr_p pdr) > > +{ > > +} > > The function itself looks correct. However, I would personally have returned > an isl_map instead of an isl_constraint. As you not

Re: [graphite] RFC: Add ISL variants of remaining PPL things

2012-06-29 Thread Tobias Grosser
On 06/26/2012 12:21 PM, Michael Matz wrote: Hi, so, to make progress on the graphite front we want to get rid of the ppl dependency. We start from Tobis move-to-isl-and-isl-scheduler branch at github, merged current trunk into that (see also Richis mails about cloog/isl configury), and add ISL