Re: [google] pessimize stack accounting during inlining

2011-06-10 Thread Richard Guenther
On Fri, Jun 10, 2011 at 1:45 AM, Mark Heffernan wrote: > On Wed, Jun 8, 2011 at 1:54 AM, Richard Guenther > wrote: >> Well, it's still not a hard limit as we can't tell how many spill slots >> or extra call argument or return value slots we need. > > Agreed.  It's not perfect.  But I've found thi

Re: [google] pessimize stack accounting during inlining

2011-06-09 Thread Mark Heffernan
On Wed, Jun 8, 2011 at 1:54 AM, Richard Guenther wrote: > Well, it's still not a hard limit as we can't tell how many spill slots > or extra call argument or return value slots we need. Agreed.  It's not perfect.  But I've found this does a reasonable job of preventing the inliner from pushing th

Re: [google] pessimize stack accounting during inlining

2011-06-08 Thread Richard Guenther
On Wed, Jun 8, 2011 at 1:36 AM, Xinliang David Li wrote: > Ok for google/main.   A good candidate patch for trunk too. Well, it's still not a hard limit as we can't tell how many spill slots or extra call argument or return value slots we need. Richard. > Thanks, > > David > > On Tue, Jun 7, 20

Re: [google] pessimize stack accounting during inlining

2011-06-07 Thread Xinliang David Li
Ok for google/main. A good candidate patch for trunk too. Thanks, David On Tue, Jun 7, 2011 at 4:29 PM, Mark Heffernan wrote: > This patch pessimizes stack accounting during inlining.  This enables > setting a firm stack size limit (via parameters "large-stack-frame" and > "large-stack-frame-