Re: [debug-early] Handle specification of class scoped static functions

2015-04-13 Thread Jason Merrill
On 04/13/2015 05:04 PM, Jason Merrill wrote: On 04/13/2015 02:01 PM, Aldy Hernandez wrote: ...or perhaps we could change the condition to: if ((is_cu_die (old_die->die_parent) + || old_die->die_parent->die_tag == DW_TAG_module || context_die == NULL Does checking context_

Re: [debug-early] Handle specification of class scoped static functions

2015-04-13 Thread Jason Merrill
On 04/13/2015 02:01 PM, Aldy Hernandez wrote: ...or perhaps we could change the condition to: if ((is_cu_die (old_die->die_parent) + || old_die->die_parent->die_tag == DW_TAG_module || context_die == NULL Does checking context_die == old_die->die_parent work? Jason

Re: [debug-early] Handle specification of class scoped static functions

2015-04-13 Thread Aldy Hernandez
On 04/03/2015 07:48 AM, Jason Merrill wrote: On 03/20/2015 08:11 PM, Aldy Hernandez wrote: + /* For class scoped static functions, the dumped early + version was the declaration, whereas the next time + around with a different context should be the + specificatio

Re: [debug-early] Handle specification of class scoped static functions

2015-04-03 Thread Jason Merrill
On 03/20/2015 08:11 PM, Aldy Hernandez wrote: + /* For class scoped static functions, the dumped early + version was the declaration, whereas the next time + around with a different context should be the + specification. In this case, avoid reusing th

Re: [debug-early] Handle specification of class scoped static functions

2015-03-20 Thread Aldy Hernandez
On 03/20/2015 02:21 PM, Jason Merrill wrote: I think we want to drop the debug_early check there entirely; the added conditions seem to be gutting it. If is_cu_die (old_die->die_parent) is false, then class_or_namespace_scope_p (old_die->die_parent) ought to be true. Jason Good catch. I am

Re: [debug-early] Handle specification of class scoped static functions

2015-03-20 Thread Jason Merrill
I think we want to drop the debug_early check there entirely; the added conditions seem to be gutting it. If is_cu_die (old_die->die_parent) is false, then class_or_namespace_scope_p (old_die->die_parent) ought to be true. Jason