Re: [committed] libstdc++: Fix preprocessor condition for inline variables

2023-03-14 Thread Daniel Krügler via Gcc-patches
Am Di., 14. März 2023 um 12:02 Uhr schrieb Jonathan Wakely : > > On Tue, 14 Mar 2023 at 10:51, Daniel Krügler wrote: >> >> Apologies for the late response: >> > > I only just committed the change, so it's not delayed :-) > > >> >> What about changing the test to check for __cpp_inline_variables or

Re: [committed] libstdc++: Fix preprocessor condition for inline variables

2023-03-14 Thread Jonathan Wakely via Gcc-patches
On Tue, 14 Mar 2023 at 10:51, Daniel Krügler wrote: > Apologies for the late response: > > I only just committed the change, so it's not delayed :-) > What about changing the test to check for __cpp_inline_variables or > combining it with __cpp_variable_templates instead? > > We could do that,

Re: [committed] libstdc++: Fix preprocessor condition for inline variables

2023-03-14 Thread Daniel Krügler via Gcc-patches
Am Di., 14. März 2023 um 11:32 Uhr schrieb Jonathan Wakely via Libstdc++ : > > Tested x86_64-linux. Pushed to trunk. > > -- >8 -- > > Although variable templates are valid in C++14, inline ones aren't. > These are only used in C++17 (or later) code, so they don't need to be > defined for C++14. > >