On Mon, Jul 20, 2020 at 1:04 PM Andrew Stubbs wrote:
>
> On 20/07/2020 11:01, Richard Biener wrote:
> > On Mon, Jul 20, 2020 at 10:40 AM Andrew Stubbs
> > wrote:
> >>
> >> On 20/07/2020 08:35, Richard Biener wrote:
> The way simple_object is supposed to work is to clone (or merge) the ELF
>
On 20/07/2020 11:01, Richard Biener wrote:
On Mon, Jul 20, 2020 at 10:40 AM Andrew Stubbs wrote:
On 20/07/2020 08:35, Richard Biener wrote:
The way simple_object is supposed to work is to clone (or merge) the ELF
headers from an existing binary. Unfortunately, the way mkoffload is
currently c
On Mon, Jul 20, 2020 at 10:40 AM Andrew Stubbs wrote:
>
> On 20/07/2020 08:35, Richard Biener wrote:
> >> The way simple_object is supposed to work is to clone (or merge) the ELF
> >> headers from an existing binary. Unfortunately, the way mkoffload is
> >> currently coded we don't have any to clo
On 20/07/2020 08:35, Richard Biener wrote:
The way simple_object is supposed to work is to clone (or merge) the ELF
headers from an existing binary. Unfortunately, the way mkoffload is
currently coded we don't have any to clone from until too late. We could
separate the assemble and link steps, b
On Fri, Jul 17, 2020 at 1:30 PM Andrew Stubbs wrote:
>
> On 17/07/2020 07:20, Thomas Schwinge wrote:
> >> --- a/gcc/config/gcn/mkoffload.c
> >> +++ b/gcc/config/gcn/mkoffload.c
> >> @@ -33,31 +33,53 @@
> >> #include
> >> #include "collect-utils.h"
> >> #include "gomp-constants.h"
> >> +#inc
On 17/07/2020 12:29, Andrew Stubbs wrote:
For easier later maintenance, shouldn't this be a '#define' (or similar)
done next to where the GCC back end defines its default?
I thought of this, but I don't think there's actually a problem. The
default is defined via OPTION_DEFAULT_SPECS, so there
On 17/07/2020 07:20, Thomas Schwinge wrote:
--- a/gcc/config/gcn/mkoffload.c
+++ b/gcc/config/gcn/mkoffload.c
@@ -33,31 +33,53 @@
#include
#include "collect-utils.h"
#include "gomp-constants.h"
+#include "simple-object.h"
+#include "elf.h"
+
+/* These probably won't be in elf.h for a while
Hi Andrew!
On 2020-07-16T16:06:49+0100, Andrew Stubbs wrote:
> This patch adds debug support to mkoffload, similar to what happens in
> lto-wrapper.
Ah, good, it's not as invasive/convoluted as I'd assumed from the verbal
description you'd given.
> Unlike lto-wrapper, we must deal with mismatch
