Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Marek Polacek
On Mon, Oct 19, 2015 at 09:59:03AM -1000, Jason Merrill wrote: > >Done. But I can't seem to commit the patch to the c++-delayed-folding > >branch; is that somehow restricted? I'm getting: > > > >svn: E170001: Commit failed (details follow): > >svn: E170001: Authorization failed > >svn: E170001: Y

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Jason Merrill
On 10/19/2015 02:31 AM, Marek Polacek wrote: On Fri, Oct 16, 2015 at 02:07:51PM -1000, Jason Merrill wrote: On 10/16/2015 07:35 AM, Marek Polacek wrote: This code path seems to be for pushing a conversion down into a binary expression. We shouldn't do this at all when we aren't folding. I te

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-19 Thread Marek Polacek
On Fri, Oct 16, 2015 at 02:07:51PM -1000, Jason Merrill wrote: > On 10/16/2015 07:35 AM, Marek Polacek wrote: > >>This code path seems to be for pushing a conversion down into a binary > >>expression. We shouldn't do this at all when we aren't folding. > > > >I tend to agree, but this case is tric

Re: [c++-delayed-folding] First stab at convert_to_integer

2015-10-16 Thread Jason Merrill
On 10/16/2015 07:35 AM, Marek Polacek wrote: This code path seems to be for pushing a conversion down into a binary expression. We shouldn't do this at all when we aren't folding. I tend to agree, but this case is tricky. What's this code about is e.g. for int fn (long p, long o) { return