Re: [WPA PATCH] Comdat group splitting

2017-01-20 Thread Nathan Sidwell
On 01/19/2017 10:26 AM, Jan Hubicka wrote: 2) For LDPR_PREVAILING_DEF members we don't make_decl_local, but instead clear DECL_COMDAT and DECL_WEAK. Thus forcing this decl to be the prevailing decl in the final link 3) For decls we localize, we also clear node->externally_visible and node->for

Re: [WPA PATCH] Comdat group splitting

2017-01-19 Thread Jan Hubicka
> honza, > this is the fix for the partitioned WPA bug I was tracking down. > > We have base and complete dtors sharing a comdat group (one's an alias for > the other). The linker tells us the complete dtor is PREVAILING_DEF, as > it's referenced from some other library. The base dtor is UNKNOWN