Re: [RS6000] num_insns_constant ICE

2018-11-30 Thread Segher Boessenkool
On Fri, Nov 30, 2018 at 06:16:40PM +1030, Alan Modra wrote: > On Thu, Nov 29, 2018 at 01:52:34PM -0600, Segher Boessenkool wrote: > > On Sun, Nov 25, 2018 at 10:49:12PM +1030, Alan Modra wrote: > > > + while (nregs-- > 0) > > > +{ > > > + int ins = num_insns_constant_gpr (value); > > > >

Re: [RS6000] num_insns_constant ICE

2018-11-29 Thread Alan Modra
On Thu, Nov 29, 2018 at 01:52:34PM -0600, Segher Boessenkool wrote: > On Sun, Nov 25, 2018 at 10:49:12PM +1030, Alan Modra wrote: > > + while (nregs-- > 0) > > +{ > > + int ins = num_insns_constant_gpr (value); > > You probably should mask "value" here so that it is only one GPR. > Alter

Re: [RS6000] num_insns_constant ICE

2018-11-29 Thread Segher Boessenkool
Hi! On Sun, Nov 25, 2018 at 10:49:12PM +1030, Alan Modra wrote: > This patch came about from investigating an ICE that appeared when I > was retesting an old half-baked patch of mine to rs6000_rtx_costs. > If a const_double is fed to rs6000_is_valid_and_mask and from there to > rs6000_is_valid_mas

Re: [RS6000] num_insns_constant ICE

2018-11-22 Thread Alan Modra
On Tue, Nov 20, 2018 at 06:07:41PM +1030, Alan Modra wrote: [snip] > alternative. movdi_internal32 used "GHF" in an alternative (and > always selected 64 byte insn length) so I replaced that with "F". Huh, no, the insn didn't have length attributes. > The FMOVE128 version of mov_softfloat also h