Re: [RFC PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-06 Thread Tobias Burnus
Tobias Burnus wrote: Regarding the patch: For gfc_error_check, I think you need to set "rc" (now: "error_raised") also when the new code is used. Otherwise, it looks good to me. Ignore that comment, I missed the existing "rc = true;" – however, you still need to the change to the new variable

Re: [RFC PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-06 Thread Mikael Morin
Le 06/12/2014 14:38, Manuel López-Ibáñez a écrit : > * Tobias or other Fortran maintainers. The only test failing is > gfortran.dg/do_iterator.f90 line 7. The old code gives an Error there, > which the new one does not. > > /home/manuel/test1/pristine/gcc/testsuite/gfortran.dg/do_iterator.f90:7.9:

Re: [RFC PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-06 Thread Tobias Burnus
Manuel López-Ibáñez wrote: I separated the diagnostics and fortran parts in two patches. This is a RFC to: * Dodji: I needed to make diagnostic_action_after_output external. [...] * Tobias or other Fortran maintainers. The only test failing is gfortran.dg/do_iterator.f90 line 7. The old code gi