Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-06 Thread Richard Biener
On Thu, Feb 6, 2025 at 2:57 PM Qing Zhao wrote: > > > > > On Feb 6, 2025, at 04:36, Richard Biener wrote: > > > > On Wed, Feb 5, 2025 at 4:40 PM Qing Zhao wrote: > >> > >> > >> > >>> On Feb 5, 2025, at 07:46, Richard Biener > >>> wrote: > >>> > >>> On Tue, Feb 4, 2025 at 10:12 PM Qing Zhao wr

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-06 Thread Qing Zhao
> On Feb 6, 2025, at 09:25, Richard Biener wrote: > > On Thu, Feb 6, 2025 at 2:57 PM Qing Zhao wrote: >> >> >> >>> On Feb 6, 2025, at 04:36, Richard Biener wrote: >>> >>> On Wed, Feb 5, 2025 at 4:40 PM Qing Zhao wrote: > On Feb 5, 2025, at 07:46, Richard Biener >>

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-06 Thread Qing Zhao
> On Feb 6, 2025, at 04:36, Richard Biener wrote: > > On Wed, Feb 5, 2025 at 4:40 PM Qing Zhao wrote: >> >> >> >>> On Feb 5, 2025, at 07:46, Richard Biener wrote: >>> >>> On Tue, Feb 4, 2025 at 10:12 PM Qing Zhao wrote: Hi, One of our big application segv in libgcc

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-06 Thread Richard Biener
On Wed, Feb 5, 2025 at 4:40 PM Qing Zhao wrote: > > > > > On Feb 5, 2025, at 07:46, Richard Biener wrote: > > > > On Tue, Feb 4, 2025 at 10:12 PM Qing Zhao wrote: > >> > >> Hi, > >> > >> One of our big application segv in libgcc code while unwinding the stack. > >> > >> This is a random crash wh

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-05 Thread Qing Zhao
> On Feb 5, 2025, at 07:49, Jakub Jelinek wrote: > > On Wed, Feb 05, 2025 at 01:46:02PM +0100, Richard Biener wrote: >>> Please let me know any comments on this? >> >> I think I've seen this elsewhere -- the issue is the unwind register API does >> not allow for failures but I also think calli

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-05 Thread Qing Zhao
> On Feb 5, 2025, at 07:46, Richard Biener wrote: > > On Tue, Feb 4, 2025 at 10:12 PM Qing Zhao wrote: >> >> Hi, >> >> One of our big application segv in libgcc code while unwinding the stack. >> >> This is a random crash while the application throws a c++ exception and >> unwinds the stack

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-05 Thread Jakub Jelinek
On Wed, Feb 05, 2025 at 01:46:02PM +0100, Richard Biener wrote: > > Please let me know any comments on this? > > I think I've seen this elsewhere -- the issue is the unwind register API does > not allow for failures but I also think calling abort() is bad. > > Are you calling this from a JIT cont

Re: [RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-05 Thread Richard Biener
On Tue, Feb 4, 2025 at 10:12 PM Qing Zhao wrote: > > Hi, > > One of our big application segv in libgcc code while unwinding the stack. > > This is a random crash while the application throws a c++ exception and > unwinds the stack. Incidents are random and never can be reproduced by any > test cas