Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Patrick O'Neill
On 12/20/23 10:41, Palmer Dabbelt wrote: On Wed, 20 Dec 2023 10:25:00 PST (-0800), jeffreya...@gmail.com wrote: On 12/20/23 11:21, Palmer Dabbelt wrote: Yea, the implementation relies largely on just pushing stuff into the constant pool, so we're largely independent ABI stuff with the like

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Palmer Dabbelt
On Wed, 20 Dec 2023 10:25:00 PST (-0800), jeffreya...@gmail.com wrote: On 12/20/23 11:21, Palmer Dabbelt wrote: Yea, the implementation relies largely on just pushing stuff into the constant pool, so we're largely independent ABI stuff with the likely exception being relocations. Ya, but I

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Jeff Law
On 12/20/23 11:21, Palmer Dabbelt wrote: Yea, the implementation relies largely on just pushing stuff into the constant pool, so we're largely independent ABI stuff with the likely exception being relocations. Ya, but I think we'd only need the relocations if we were going to try relaxing

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Palmer Dabbelt
On Wed, 20 Dec 2023 10:12:04 PST (-0800), jeffreya...@gmail.com wrote: On 12/20/23 11:05, Palmer Dabbelt wrote: On Wed, 20 Dec 2023 09:55:48 PST (-0800), jeffreya...@gmail.com wrote: On 12/18/23 00:46, KuanLin Chen wrote: Hi Jeff, Sorry for this missing. I've removed riscv_asm_output_pool

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Jeff Law
On 12/20/23 11:05, Palmer Dabbelt wrote: On Wed, 20 Dec 2023 09:55:48 PST (-0800), jeffreya...@gmail.com wrote: On 12/18/23 00:46, KuanLin Chen wrote: Hi Jeff, Sorry for this missing. I've removed riscv_asm_output_pool_epilogue because the pool beginning is always aligned from FUNCTION_BO

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Palmer Dabbelt
On Wed, 20 Dec 2023 09:55:48 PST (-0800), jeffreya...@gmail.com wrote: On 12/18/23 00:46, KuanLin Chen wrote: Hi Jeff, Sorry for this missing. I've removed riscv_asm_output_pool_epilogue because the pool beginning is always aligned from FUNCTION_BOUNDARY. Please find attached. Thank you. Tha

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-20 Thread Jeff Law
On 12/18/23 00:46, KuanLin Chen wrote: Hi Jeff, Sorry for this missing. I've removed riscv_asm_output_pool_epilogue because the pool beginning is always aligned from FUNCTION_BOUNDARY. Please find attached. Thank you. Thanks. I regression tested this on rv64gc without any issues and fixed

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-17 Thread KuanLin Chen
Hi Jeff, Sorry for this missing. I've removed riscv_asm_output_pool_epilogue because the pool beginning is always aligned from FUNCTION_BOUNDARY. Please find attached. Thank you. Jeff Law 於 2023年12月18日 週一 上午3:15寫道: > > > On 11/10/23 02:10, KuanLin Chen wrote: > > Sorry. It missed a semicolon in

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-12-17 Thread Jeff Law
On 11/10/23 02:10, KuanLin Chen wrote: Sorry. It missed a semicolon in the previos patch. Please find the new one in the attachment. Thanks. Thanks. I was going to do some final testing with the plan to integrate this patch today, but I think there's a piece missing. Specifically I think i

Re: [RFC][V2] RISC-V: Support -mcmodel=large.

2023-11-10 Thread KuanLin Chen
Sorry. It missed a semicolon in the previos patch. Please find the new one in the attachment. Thanks. 0001-RISC-V-Support-mcmodel-large.patch Description: Binary data