Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-08-01 Thread Wilco Dijkstra
       ping     Wilco Dijkstra wrote: > James Greenhalgh wrote: > > > I note this is still marked as an RFC, are you now proposing it as a > > patch to be merged to trunk? > > Absolutely. It was marked as an RFC to get some comments - I thought it > may be controversial to separate the frame po

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-07-21 Thread Wilco Dijkstra
      ping     Wilco Dijkstra wrote: > James Greenhalgh wrote: > > > I note this is still marked as an RFC, are you now proposing it as a > > patch to be merged to trunk? > > Absolutely. It was marked as an RFC to get some comments - I thought it > may be controversial to separate the frame po

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-07-14 Thread Wilco Dijkstra
  ping     Wilco Dijkstra wrote: > James Greenhalgh wrote: > > > I note this is still marked as an RFC, are you now proposing it as a > > patch to be merged to trunk? > > Absolutely. It was marked as an RFC to get some comments - I thought it > may be controversial to separate the frame pointe

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-27 Thread Wilco Dijkstra
ping   Wilco Dijkstra wrote: > James Greenhalgh wrote: > > > I note this is still marked as an RFC, are you now proposing it as a > > patch to be merged to trunk? > > Absolutely. It was marked as an RFC to get some comments - I thought it > may be controversial to separate the frame pointer and

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-15 Thread Wilco Dijkstra
Jiong Wang wrote: test.c === struct K {   int a;   int b;   int c;   int d;   char e;   short f;   long g;   float h;   double i; }; void foo (int, struct K *); void test (int i) {   struct K k = {    .a = 5,    .b = 0,    .c = i,   };   foo (5, &k); } There are 2 separate latent bugs here, bo

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-15 Thread Jiong Wang
On 15/06/17 15:12, Wilco Dijkstra wrote: This results in smaller code and unwind info. I have done a quick test on your updated patch through building latest linux kernel. Dwarf frame size improved (~ 5% smaller) as using sp to address locals doesn't need to update CFA register etc. Though th

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-15 Thread Wilco Dijkstra
Wilco Dijkstra wrote: > James Greenhalgh wrote: > > > I note this is still marked as an RFC, are you now proposing it as a > > patch to be merged to trunk? > > Absolutely. It was marked as an RFC to get some comments - I thought it > may be controversial to separate the frame pointer and frame cha

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-14 Thread Wilco Dijkstra
James Greenhalgh wrote: > I note this is still marked as an RFC, are you now proposing it as a > patch to be merged to trunk? Absolutely. It was marked as an RFC to get some comments - I thought it may be controversial to separate the frame pointer and frame chain concept. And this fixes the lon

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-14 Thread James Greenhalgh
On Mon, Oct 31, 2016 at 06:29:21PM +, Wilco Dijkstra wrote: > This patch cleans up all code related to the frame pointer. On AArch64 we > emit a frame chain even in cases where the frame pointer is not required. > So make this explicit by introducing a boolean emit_frame_chain in > aarch64_fra

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage     This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So make

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-04-20 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage   This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So make

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2017-01-17 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage     This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So ma

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2016-12-14 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage     This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So m

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2016-12-06 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage     This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required.

Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage

2016-11-14 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 31 October 2016 18:29 To: GCC Patches Cc: nd Subject: [RFC][PATCH][AArch64] Cleanup frame pointer usage   This patch cleans up all code related to the frame pointer.  On AArch64 we emit a frame chain even in cases where the frame pointer is not required. So mak