Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-08-17 Thread Richard Biener
On Wed, Aug 17, 2016 at 4:50 AM, kugan wrote: > Hi Richard, > > > On 17/08/16 08:20, kugan wrote: >> >> Hi, >> >> On 16/08/16 21:56, Richard Biener wrote: >>> >>> On Tue, Aug 16, 2016 at 10:09 AM, kugan >>> wrote: On 23/07/16 20:12, kugan wrote: > > > Hi Richa

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-08-16 Thread kugan
Hi Richard, On 17/08/16 08:20, kugan wrote: Hi, On 16/08/16 21:56, Richard Biener wrote: On Tue, Aug 16, 2016 at 10:09 AM, kugan wrote: On 23/07/16 20:12, kugan wrote: Hi Richard, As we had value_range_type in tree-ssanames.h why not put value_range there? For IPA_VRP, we now need v

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-08-16 Thread kugan
Hi, On 16/08/16 21:56, Richard Biener wrote: On Tue, Aug 16, 2016 at 10:09 AM, kugan wrote: On 23/07/16 20:12, kugan wrote: Hi Richard, As we had value_range_type in tree-ssanames.h why not put value_range there? For IPA_VRP, we now need value_range used in ipa-prop.h (in ipa-vrp patc

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-08-16 Thread Richard Biener
On Tue, Aug 16, 2016 at 10:09 AM, kugan wrote: > > > > On 23/07/16 20:12, kugan wrote: >> >> Hi Richard, >> As we had value_range_type in tree-ssanames.h why not put value_range there? >>> For IPA_VRP, we now need value_range used in ipa-prop.h (in ipa-vrp >>> patch). Based on this,

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-08-16 Thread kugan
On 23/07/16 20:12, kugan wrote: Hi Richard, As we had value_range_type in tree-ssanames.h why not put value_range there? For IPA_VRP, we now need value_range used in ipa-prop.h (in ipa-vrp patch). Based on this, attached patch now adds struct value_range to tree-ssanames.h and fixes the he

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-07-23 Thread kugan
Hi Richard, As we had value_range_type in tree-ssanames.h why not put value_range there? For IPA_VRP, we now need value_range used in ipa-prop.h (in ipa-vrp patch). Based on this, attached patch now adds struct value_range to tree-ssanames.h and fixes the header files. Please note that I also

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-07-22 Thread kugan
Hi Richard, Thanks for the review. On 22/07/16 22:49, Richard Biener wrote: On Fri, Jul 22, 2016 at 2:27 PM, kugan wrote: Hi, Now that early vrp is moved as part of tree-vrp, there is only minimal interface tree-vrp should expose for ipa-vrp. However, I have not found the right place to plac

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-07-22 Thread Richard Biener
On Fri, Jul 22, 2016 at 2:27 PM, kugan wrote: > Hi, > > Now that early vrp is moved as part of tree-vrp, there is only minimal > interface tree-vrp should expose for ipa-vrp. However, I have not found the > right place to place struct value_range (with GTY marker) and enum > value_range_type. > >

Re: [RFC][IPA-VRP] Re-factor tree-vrp to factor out common code

2016-07-22 Thread kugan
Hi, Now that early vrp is moved as part of tree-vrp, there is only minimal interface tree-vrp should expose for ipa-vrp. However, I have not found the right place to place struct value_range (with GTY marker) and enum value_range_type. enum value_range_type is needed in tree-ssanames.[h|c] a