Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-06-09 Thread Mariam Arutunian
On Sat, Jun 8, 2024, 09:53 Richard Sandiford wrote: > Thanks a lot for doing this! It's a really nice series. > Thank you for your positive feedback and for your review and suggestions on the patch series. Just had a comment on the long division helper: > > Mariam Arutunian writes: > > +/* R

Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-06-08 Thread Jeff Law
On 6/8/24 1:53 AM, Richard Sandiford wrote: I realise there are many ways of writing this out there though, so that's just a suggestion. (And only lightly tested.) FWIW, we could easily extend the interface to work on wide_ints if we ever need it for N>63. I think there's constraints elsew

Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-06-08 Thread Richard Sandiford
Thanks a lot for doing this! It's a really nice series. Just had a comment on the long division helper: Mariam Arutunian writes: > +/* Return the quotient of polynomial long division of x^2N by POLYNOMIAL > + in GF (2^N). */ It looks like there might be an off-by-one discrepancy between the

Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-05-27 Thread Mariam Arutunian
On Sat, May 25, 2024 at 10:32 PM Jeff Law wrote: > > > On 5/24/24 2:41 AM, Mariam Arutunian wrote: > > If the target is ZBC or ZBKC, it uses clmul instruction for the CRC > > calculation. > > Otherwise, if the target is ZBKB, generates table-based CRC, > > but for reversing inputs and the output

Re: [RFC/RFA] [PATCH 03/12] RISC-V: Add CRC expander to generate faster CRC.

2024-05-25 Thread Jeff Law
On 5/24/24 2:41 AM, Mariam Arutunian wrote: If the target is ZBC or ZBKC, it uses clmul instruction for the CRC calculation. Otherwise, if the target is ZBKB, generates table-based CRC, but for reversing inputs and the output uses bswap and brev8 instructions. Add new tests to check CRC gener