Re: [RFC, testsuite] Add dg-save-linenr

2020-11-17 Thread Jeff Law via Gcc-patches
On 10/30/20 5:34 AM, Thomas Schwinge wrote: > Hi! > > On 2017-05-22T18:55:29+0200, Tom de Vries wrote: >> On 05/16/2017 03:12 PM, Rainer Orth wrote: >>> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. >> Attached patch adds the missing documentation. > OK to expand th

Re: [RFC, testsuite] Add dg-save-linenr

2020-10-30 Thread Thomas Schwinge
Hi Jakub! On 2020-10-30T12:40:02+0100, Jakub Jelinek wrote: > On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote: >> On 2017-05-22T18:55:29+0200, Tom de Vries wrote: >> > On 05/16/2017 03:12 PM, Rainer Orth wrote: >> >> [...], but the new proc ['dg-line'] needs documenting in source

Re: [RFC, testsuite] Add dg-save-linenr

2020-10-30 Thread Jakub Jelinek via Gcc-patches
On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote: > Hi! > > On 2017-05-22T18:55:29+0200, Tom de Vries wrote: > > On 05/16/2017 03:12 PM, Rainer Orth wrote: > >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. > > > > Attached patch adds the missing docume

Re: [RFC, testsuite] Add dg-save-linenr

2020-10-30 Thread Thomas Schwinge
Hi! On 2017-05-22T18:55:29+0200, Tom de Vries wrote: > On 05/16/2017 03:12 PM, Rainer Orth wrote: >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. > > Attached patch adds the missing documentation. OK to expand that with the attached patch to "Document that 'linenumv

Re: [RFC, testsuite] Add dg-save-linenr

2017-05-23 Thread Mike Stump
On May 22, 2017, at 9:55 AM, Tom de Vries wrote: > > Attached patch adds the missing documentation. > > It looks like this in gccint.info: > ... > '{ dg-line LINENUMVAR }' > This DejaGnu directive sets the variable LINENUMVAR to the line > number of the source line. The variable LINENUM

Re: [RFC, testsuite] Add dg-save-linenr

2017-05-23 Thread Tom de Vries
On 05/22/2017 06:55 PM, Tom de Vries wrote: Besides, it may be worthwhile contributing/suggesting this upstream. Will do. Sent 'relative line numbers and dg-line directive' to dejagnu ml ( http://lists.gnu.org/archive/html/dejagnu/2017-05/msg0.html ). Thanks, - Tom

Re: [RFC, testsuite] Add dg-save-linenr

2017-05-22 Thread Tom de Vries
On 05/16/2017 03:12 PM, Rainer Orth wrote: Hi Tom, sorry for chiming in so very late: I've been on vacation and sick in between... thanks for review anyway. On 04/24/2017 05:20 PM, David Malcolm wrote: On Sat, 2017-04-22 at 19:49 +0200, Tom de Vries wrote: Hi, there are currently two typ

Re: [RFC, testsuite] Add dg-save-linenr

2017-05-16 Thread Rainer Orth
Hi Tom, sorry for chiming in so very late: I've been on vacation and sick in between... > On 04/24/2017 05:20 PM, David Malcolm wrote: >> On Sat, 2017-04-22 at 19:49 +0200, Tom de Vries wrote: >>> Hi, >>> >>> there are currently two types of line number supported in >>> dg-{error,warning,message

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-25 Thread Mike Stump
On Apr 25, 2017, at 8:21 AM, Tom de Vries wrote: > > OK for trunk? Ok.

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-25 Thread Tom de Vries
On 04/24/2017 05:20 PM, David Malcolm wrote: On Sat, 2017-04-22 at 19:49 +0200, Tom de Vries wrote: Hi, there are currently two types of line number supported in dg-{error,warning,message,bogus} directives: absolute and relative. With an absolute line number, it's immediately clear what line nu

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-25 Thread Jeff Law
On 04/22/2017 11:49 AM, Tom de Vries wrote: Hi, there are currently two types of line number supported in dg-{error,warning,message,bogus} directives: absolute and relative. With an absolute line number, it's immediately clear what line number is meant, but when a line is added at the start of

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-24 Thread David Malcolm
On Mon, 2017-04-24 at 11:20 -0400, David Malcolm wrote: > On Sat, 2017-04-22 at 19:49 +0200, Tom de Vries wrote: > > Hi, > > > > there are currently two types of line number supported in > > dg-{error,warning,message,bogus} directives: absolute and relative. > > With an absolute line number, it's

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-24 Thread David Malcolm
On Sat, 2017-04-22 at 19:49 +0200, Tom de Vries wrote: > Hi, > > there are currently two types of line number supported in > dg-{error,warning,message,bogus} directives: absolute and relative. > With an absolute line number, it's immediately clear what line number > is > meant, but when a line i

Re: [RFC, testsuite] Add dg-save-linenr

2017-04-22 Thread Mike Stump
On Apr 22, 2017, at 10:49 AM, Tom de Vries wrote: > > This patch adds a directive dg-save-linenr with argument varname, that saves > the line number of the directive in a variable varname, which can be used as > line number in dg directives. > RFC: > - good idea? Seems reasonable to me. I'd