Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-18 Thread Richard Biener
On July 17, 2015 11:28:28 PM GMT+02:00, Ulrich Weigand wrote: >On July 17, 2015 6:54:32 PM GMT+02:00, Ulrich Weigand > wrote: >> >So do we now consider host compilers < 4.3 (4?) unsupported for >> >building >> >mainline GCC, or should we try to work around the issue (e.g. by >moving >> >the alloc

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Ulrich Weigand
On July 17, 2015 6:54:32 PM GMT+02:00, Ulrich Weigand wrote: > >So do we now consider host compilers < 4.3 (4?) unsupported for > >building > >mainline GCC, or should we try to work around the issue (e.g. by moving > >the allocator out-of-line or using some other aliasing barrier)? > > Why is th

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Martin Liška
On 07/17/2015 05:03 PM, Richard Biener wrote: > On July 17, 2015 3:50:19 PM GMT+02:00, "Martin Liška" wrote: >> On 07/17/2015 03:44 PM, Ulrich Weigand wrote: >>> Richard Biener wrote: On July 17, 2015 3:11:51 PM GMT+02:00, Ulrich Weigand >> wrote: > (Since there is no C++ operator new in

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Richard Biener
On July 17, 2015 6:54:32 PM GMT+02:00, Ulrich Weigand wrote: >Richard Biener wrote: >> On July 17, 2015 3:50:19 PM GMT+02:00, "Martin Liška" > wrote: >> >Question is why aliasing oracle still wrongly aliases these >pointers? >> >Another option (suggested by Martin Jambor) would be to place >> >:

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Ulrich Weigand
Richard Biener wrote: > On July 17, 2015 3:50:19 PM GMT+02:00, "Martin Liška" wrote: > >Question is why aliasing oracle still wrongly aliases these pointers? > >Another option (suggested by Martin Jambor) would be to place > >::allocate implementation > >to alloc-pool.c file. > > Note that all c

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Richard Biener
On July 17, 2015 3:50:19 PM GMT+02:00, "Martin Liška" wrote: >On 07/17/2015 03:44 PM, Ulrich Weigand wrote: >> Richard Biener wrote: >>> On July 17, 2015 3:11:51 PM GMT+02:00, Ulrich Weigand > wrote: (Since there is no C++ operator new involved at all anymore, this clearly violates even

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Martin Liška
On 07/17/2015 03:44 PM, Ulrich Weigand wrote: > Richard Biener wrote: >> On July 17, 2015 3:11:51 PM GMT+02:00, Ulrich Weigand >> wrote: >>> (Since there is no C++ operator new involved at all anymore, >>> this clearly violates even the C aliasing rules ...) >>> >>> I really think the allocate ro

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Ulrich Weigand
Richard Biener wrote: > On July 17, 2015 3:11:51 PM GMT+02:00, Ulrich Weigand > wrote: > >(Since there is no C++ operator new involved at all anymore, > >this clearly violates even the C aliasing rules ...) > > > >I really think the allocate routine needs to be more careful to > >avoid violating

Re: Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Richard Biener
On July 17, 2015 3:11:51 PM GMT+02:00, Ulrich Weigand wrote: >On 07/09/2015 11:43 PM, Martin Liška wrote: > >> This final version which I agreed with Richard Sandiford. >> Hope this can be finally installed to trunk? >> >> Patch can bootstrap and survive regression tests on x86_64-linux-gnu. >

Still crashes due to aliasing violation (Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator)

2015-07-17 Thread Ulrich Weigand
On 07/09/2015 11:43 PM, Martin Liška wrote: > This final version which I agreed with Richard Sandiford. > Hope this can be finally installed to trunk? > > Patch can bootstrap and survive regression tests on x86_64-linux-gnu. Unfortunately, this still crashes on my SPU toolchain build machine, f

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-16 Thread Richard Biener
On Thu, Jul 16, 2015 at 12:47 PM, Martin Liška wrote: > On 07/09/2015 11:43 PM, Martin Liška wrote: >> On 07/03/2015 06:18 PM, Richard Sandiford wrote: >>> Hi Martin, >>> >>> Martin Liška writes: On 07/03/2015 03:07 PM, Richard Sandiford wrote: > Martin Jambor writes: >> On Fri, Jul

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-16 Thread Martin Liška
On 07/09/2015 11:43 PM, Martin Liška wrote: > On 07/03/2015 06:18 PM, Richard Sandiford wrote: >> Hi Martin, >> >> Martin Liška writes: >>> On 07/03/2015 03:07 PM, Richard Sandiford wrote: Martin Jambor writes: > On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: >> T

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-10 Thread Pat Haugen
On 07/09/2015 04:43 PM, Martin Liška wrote: This final version which I agreed with Richard Sandiford. Hope this can be finally installed to trunk? Patch can bootstrap and survive regression tests on x86_64-linux-gnu. FWIW, I confirmed this version of the patch fixes the build issues on powerpc6

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-09 Thread Martin Liška
On 07/03/2015 06:18 PM, Richard Sandiford wrote: Hi Martin, Martin Liška writes: On 07/03/2015 03:07 PM, Richard Sandiford wrote: Martin Jambor writes: On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: Trevor Saunders writes: On Thu, Jul 02, 2015 at 09:09:31PM +0100, Ric

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Richard Sandiford
Hi Martin, Martin Liška writes: > On 07/03/2015 03:07 PM, Richard Sandiford wrote: >> Martin Jambor writes: >>> On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: Trevor Saunders writes: > On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: >> Martin

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Martin Liška
On 07/03/2015 03:07 PM, Richard Sandiford wrote: > Martin Jambor writes: >> On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: >>> Trevor Saunders writes: On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: > Martin Liška writes: >> diff --git a/gcc/as

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Richard Sandiford
Martin Jambor writes: > On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: >> Trevor Saunders writes: >> > On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: >> >> Martin Liška writes: >> >> > diff --git a/gcc/asan.c b/gcc/asan.c >> >> > index e89817e..dabd6f1 100

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Martin Jambor
Hi, On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: > >> Martin Liška writes: > >> > diff --git a/gcc/asan.c b/gcc/asan.c > >> > index e89817e..dabd6f1 100644 > >> > --- a/gcc/asan

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Martin Liška
On 07/03/2015 10:55 AM, Richard Sandiford wrote: > Trevor Saunders writes: >> On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: >>> Martin Liška writes: diff --git a/gcc/asan.c b/gcc/asan.c index e89817e..dabd6f1 100644 --- a/gcc/asan.c +++ b/gcc/asan.c @

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-03 Thread Richard Sandiford
Trevor Saunders writes: > On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: >> Martin Liška writes: >> > diff --git a/gcc/asan.c b/gcc/asan.c >> > index e89817e..dabd6f1 100644 >> > --- a/gcc/asan.c >> > +++ b/gcc/asan.c >> > @@ -362,20 +362,20 @@ struct asan_mem_ref >> >/* P

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-02 Thread Trevor Saunders
On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: > Martin Liška writes: > > diff --git a/gcc/asan.c b/gcc/asan.c > > index e89817e..dabd6f1 100644 > > --- a/gcc/asan.c > > +++ b/gcc/asan.c > > @@ -362,20 +362,20 @@ struct asan_mem_ref > >/* Pool allocation new operator. */ >

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-02 Thread Richard Sandiford
Martin Liška writes: > @@ -136,18 +135,18 @@ private: > int64_t align_i; >} u; > > -static inline allocation_object * > +static inline allocation_object* space before "*" > get_instance (void *data_ptr) > { > - return (allocation_object *)(((char *)(data_pt