Re: [Patch] match_results::format and regex_replace

2013-09-24 Thread Ed Smith-Rowland
On 09/23/2013 10:09 PM, Tim Shen wrote: On Sun, Sep 22, 2013 at 4:20 PM, Paolo Carlini wrote: If testing goes well patch is Ok to commit. Tested under -m32 and -m64 and committed :) I'll learn how locale in glibc works. Thank you all! Thank *you*! has been dogging us for years. I, for

Re: [Patch] match_results::format and regex_replace

2013-09-23 Thread Tim Shen
On Sun, Sep 22, 2013 at 4:20 PM, Paolo Carlini wrote: > If testing goes well patch is Ok to commit. Tested under -m32 and -m64 and committed :) I'll learn how locale in glibc works. Thank you all! -- Tim Shen

Re: [Patch] match_results::format and regex_replace

2013-09-22 Thread Paolo Carlini
Hi, Tim Shen ha scritto: >I think I get it this time :) > >Now we have "regex.tcc". > >I'll do a full test before committing. If testing goes well patch is Ok to commit. Thanks! Paolo

Re: [Patch] match_results::format and regex_replace

2013-09-20 Thread Paolo Carlini
Great indeed! More comments later. First nit: please review the various regex_replace overloads vs inline: if I'm not misreading the diff I see large ones inline and small ones out of line!?! Should we have a regex.tcc? Also, old story about ChangeLogs ;) This is not ok: * include/bi