On 09/12/2013 06:20 PM, Tim Shen wrote:
On Thu, Sep 12, 2013 at 12:00 PM, Jakub Jelinek wrote:
That is not the right test, because you need to count all tabs (at least
the leading ones, you probably shouldn't have other tabs) as 8 columns
rather than just one. And there are 11 lines that are o
On Thu, Sep 12, 2013 at 11:51:57AM -0400, Tim Shen wrote:
> On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini
> wrote:
> > .. please fix the overlong lines, I spotted quite a few.
>
> Quite a few? I see only one line by casting:
> egrep '^\+.{80}' a.patch
>
> Even it's not 81.
That is not the rig
On Thu, Sep 12, 2013 at 9:57 AM, Paolo Carlini wrote:
> Great. A quick-quick comment: if these are the last two features, why we
> can't un-xfail the testcase which we added latety? Also, a grep revealed a
> couple more xfails. Can you clarify?
I say `feature` when I think that, what these xfails
On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini
wrote:
> .. please fix the overlong lines, I spotted quite a few.
Quite a few? I see only one line by casting:
egrep '^\+.{80}' a.patch
Even it's not 81.
That'll be fixed before committing.
Seriously, I think we need an AST-based formatter? Clang
.. please fix the overlong lines, I spotted quite a few.
Paolo.
Hi,
On 09/12/2013 04:51 PM, Tim Shen wrote:
On Thu, Sep 12, 2013 at 9:57 AM, Paolo Carlini wrote:
Great. A quick-quick comment: if these are the last two features, why we
can't un-xfail the testcase which we added latety? Also, a grep revealed a
couple more xfails. Can you clarify?
I say `fea
Hi,
On 09/12/2013 03:25 PM, Tim Shen wrote:
This patch implement the (expecting) last two features in regex. Work
is easier after this ;)
Great. A quick-quick comment: if these are the last two features, why we
can't un-xfail the testcase which we added latety? Also, a grep revealed
a couple m
