Re: [Patch] Avoid gcc_assert in libgcov

2014-05-22 Thread Rong Xu
I think these asserts will be used by gcov-tool. So I prefer to change them to gcov_nonruntime_assert(). I'll merge them in my new gcov-tool patch before submitting (waiting for honaz's ok). Thanks, -Rong On Thu, May 22, 2014 at 7:09 AM, Teresa Johnson wrote: > On Thu, Jan 16, 2014 at 2:41 PM,

Re: [Patch] Avoid gcc_assert in libgcov

2014-05-22 Thread Teresa Johnson
On Thu, Jan 16, 2014 at 2:41 PM, Jan Hubicka wrote: >> On Wed, Jan 15, 2014 at 8:39 PM, Jan Hubicka wrote: >> >> >> >> In that case should we call gcov_error when IN_LIBGCOV? One >> >> possibility would be to simply make gcov_nonruntime_assert be defined >> >> as if (!EXPR) gcov_error in the IN_L

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-16 Thread Jan Hubicka
> On Wed, Jan 15, 2014 at 8:39 PM, Jan Hubicka wrote: > >> > >> In that case should we call gcov_error when IN_LIBGCOV? One > >> possibility would be to simply make gcov_nonruntime_assert be defined > >> as if (!EXPR) gcov_error in the IN_LIBGCOV case. But I think what you > >> wanted here was to

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-16 Thread Teresa Johnson
On Wed, Jan 15, 2014 at 8:39 PM, Jan Hubicka wrote: >> >> In that case should we call gcov_error when IN_LIBGCOV? One >> possibility would be to simply make gcov_nonruntime_assert be defined >> as if (!EXPR) gcov_error in the IN_LIBGCOV case. But I think what you >> wanted here was to reduce libgc

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-15 Thread Jan Hubicka
> > In that case should we call gcov_error when IN_LIBGCOV? One > possibility would be to simply make gcov_nonruntime_assert be defined > as if (!EXPR) gcov_error in the IN_LIBGCOV case. But I think what you > wanted here was to reduce libgcov bloat by removing calls altogether, > which this would

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-14 Thread Teresa Johnson
On Thu, Jan 9, 2014 at 6:56 AM, Jan Hubicka wrote: >> As suggested by Honza, avoid bloating libgcov from gcc_assert by using >> a new macro gcov_nonruntime_assert in gcov-io.c that is only mapped to >> gcc_assert when not in libgcov. >> >> Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok fo

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-09 Thread Jan Hubicka
> As suggested by Honza, avoid bloating libgcov from gcc_assert by using > a new macro gcov_nonruntime_assert in gcov-io.c that is only mapped to > gcc_assert when not in libgcov. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? > > Thanks, > Teresa > > 2014-01-09 Teresa J