Re: [PR86153] simplify more overflow tests in VRP

2018-12-28 Thread Alexandre Oliva
On Dec 19, 2018, Alexandre Oliva wrote: > + op1 = x; > + code = (code == LT_EXPR || code == LE_EXPR) ? LE_EXPR : GT_EXPR; So... I've done some more testing, and this alone seems to overlap nicely with what's in the trunk ATM, with a few exceptions: - for some reason, LE/GT do not get

Re: [PR86153] simplify more overflow tests in VRP

2018-12-19 Thread Alexandre Oliva
On Dec 18, 2018, Jeff Law wrote: >> Although such overflow tests could be uniformly simplified to compares >> against a constant, the original code would only perform such >> simplifications when the test could be resolved to an equality test >> against zero. I've thus avoided introducing compar

Re: [PR86153] simplify more overflow tests in VRP

2018-12-18 Thread Jeff Law
On 12/18/18 3:58 AM, Alexandre Oliva wrote: > Jeff, you mentioned you had changes to the VRP overflow test that would > fix this, but I couldn't figure out whether or not you ever put them in > and it regressed again later, or what. Anyway, here's my take on it. No, they're not on the trunk yet.