Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/09/12 06:04:28, Gary Funck wrote: > On 01/09/12 12:08:22, Tobias Burnus wrote: > > I get the build failure: > > > > libcpp/macro.c:220:26: error: variable 'map' set but not used > > [-Werror=unused-but-set-variable] Richard, thanks. 2012-01-09 Richard Guenther libcpp/ *

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/09/12 12:08:22, Tobias Burnus wrote: > I get the build failure: > > libcpp/macro.c:220:26: error: variable 'map' set but not used > [-Werror=unused-but-set-variable] Tobias, thanks. Will fix. - Gary

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Dominique Dhumieres
> I get the build failure: ... I got the same failure. The following patch --- ../_clean/libcpp/macro.c2012-01-09 11:15:22.0 +0100 +++ ../work/libcpp/macro.c 2012-01-09 12:28:06.0 +0100 @@ -217,7 +217,7 @@ static const char * const monthnames[] = const uchar * _cpp_buil

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Tobias Burnus
On 01/09/2012 10:02 AM, Gary Funck wrote: On 01/06/12 08:34:52, Tom Tromey wrote: The patch is ok with either that change or with those 2 lines removed. Applied as svn version 183003. I get the build failure: libcpp/macro.c:220:26: error: variable 'map' set but not used [-Werror=unused-but

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-09 Thread Gary Funck
On 01/06/12 08:34:52, Tom Tromey wrote: > The patch is ok with either that change or with those 2 lines removed. Applied as svn version 183003.

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Gary Funck
On 01/06/12 08:34:52, Tom Tromey wrote: Tom> The patch is ok with either that change or with those 2 lines removed. Tom, thanks for the review. Another question ... The test case tries to sanity check the __FILE__ value by comparing the 'basename' part. #define BASE_NAME "pr33919.c" in

Re: [PING] PR33919/preprocessor fix __BASE_FILE__ when included from the command line

2012-01-06 Thread Tom Tromey
> "Gary" == Gary Funck writes: Gary> I have a specific question re: this new code. Gary> + name = _cpp_get_file_name (pfile->main_file); Gary> + if (!name) Gary> + name = ""; Gary> I wasn't sure whether 'name' can have a NULL value, and handled Gary> that case