Re: [PATCH v9] Practical improvement to libgcc complex divide

2021-04-01 Thread Patrick McGehearty via Gcc-patches
I would very much like to get all the details right on my next submission. I'm submitting this query for feedback before I do the full submission. Most changes requested require obvious fixes. One has me confused about the best action to take. - - - - On the issue of alloca vs XALLOCAVEC, I dis

Re: [PATCH v9] Practical improvement to libgcc complex divide

2021-03-31 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 26 Mar 2021 23:14:41 + Patrick McGehearty via Gcc-patches wrote: > diff --git a/gcc/c-family/c-cppbuiltin.c b/gcc/c-family/c-cppbuiltin.c > index 9f993c4..c0d9e57 100644 > --- a/gcc/c-family/c-cppbuiltin.c > +++ b/gcc/c-family/c-cppbuiltin.c > @@ -1277,8 +1277,10 @@ c_cpp_builtins (cp

Re: [PATCH v9] Practical improvement to libgcc complex divide

2021-03-30 Thread Patrick McGehearty via Gcc-patches
Thank you for your interest in this project. On 3/27/2021 6:18 PM, Bernhard Reutner-Fischer wrote: On Fri, 26 Mar 2021 23:14:41 + Patrick McGehearty via Gcc-patches wrote: Changes in Version 9 since Version 8: Revised code to meet gcc coding standards in all files, especially with r

Re: [PATCH v9] Practical improvement to libgcc complex divide

2021-03-27 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 26 Mar 2021 23:14:41 + Patrick McGehearty via Gcc-patches wrote: > Changes in Version 9 since Version 8: > > Revised code to meet gcc coding standards in all files, especially > with respect to adding spaces around operations and removing > excess () in #define macro definiti