I decided to use float_h_prefix instead of modename or mode prefix
as Joseph has better insight as to naming expectations when
others are working in gcc/c-family/c-cppbuiltin.c.
All requested changes made and tested. Patch coming shortly.
- patrick
On 2/19/2021 5:48 PM, Joseph Myers wrote:
On
On Fri, 19 Feb 2021, Patrick McGehearty via Gcc-patches wrote:
> > Here you're properly computing the mapping from mode to float.h macro
> > prefix (though I think "modename" is a confusing name for the variable
> > used for float.h macro prefixes; to me, "modename" suggests the names such
> > as
Comments inline
On 2/19/2021 3:27 PM, Joseph Myers wrote:
On Tue, 2 Feb 2021, Patrick McGehearty via Gcc-patches wrote:
if (mode == TYPE_MODE (double_type_node))
- ; /* Empty suffix correct. */
+ {
+ ; /* Empty suffix correct. */
+ memcpy
On Tue, 2 Feb 2021, Patrick McGehearty via Gcc-patches wrote:
> if (mode == TYPE_MODE (double_type_node))
> - ; /* Empty suffix correct. */
> + {
> + ; /* Empty suffix correct. */
> + memcpy (modename, "DBL", 4);
> + }
> else if (mode =
Ping - Submitted Feb 2, 2021
I believe this version fixes all issues raised
in previous submissions.
- Patrick McGehearty
On 2/2/2021 4:25 PM, Patrick McGehearty via Gcc-patches wrote:
Changes in this version from Version 6:
Updated copyrights for following three files to -2021.