Re: [PATCH v4] libstdc++: implement concatenation of strings and string_views

2024-10-25 Thread Jonathan Wakely
On Sun, 13 Oct 2024 at 18:59, Giuseppe D'Angelo wrote: > > Hello, > > On 09/10/2024 22:39, Patrick Palka wrote: > >> +#if __glibcxx_string_view >= 202403L > >> + // const string & + string_view > >> + template > >> +[[nodiscard]] > >> +constexpr inline basic_string<_CharT, _Traits, _Allo

Re: [PATCH v4] libstdc++: implement concatenation of strings and string_views

2024-10-20 Thread François Dumont
On 17/10/2024 11:13, Giuseppe D'Angelo wrote: Hello, Il 17/10/24 06:32, François Dumont ha scritto: As a side note you should provide your patches as .txt files so that any email client can render it without going through an editor. Apologies for that. Do you mean I should use text/plain at

Re: [PATCH v4] libstdc++: implement concatenation of strings and string_views

2024-10-17 Thread Giuseppe D'Angelo
Hello, Il 17/10/24 06:32, François Dumont ha scritto: As a side note you should provide your patches as .txt files so that any email client can render it without going through an editor. Apologies for that. Do you mean I should use text/plain attachments instead of text/x-patch? And regar

Re: [PATCH v4] libstdc++: implement concatenation of strings and string_views

2024-10-16 Thread François Dumont
As a side note you should provide your patches as .txt files so that any email client can render it without going through an editor. And regarding the patch, I wonder what the std::move is for on the returned value ? Like this one: +    { +  return std::move(__lhs.append(__rhs)); +    }

Re: [PATCH v4] libstdc++: implement concatenation of strings and string_views

2024-10-13 Thread Giuseppe D'Angelo
Hello, On 09/10/2024 22:39, Patrick Palka wrote: +#if __glibcxx_string_view >= 202403L + // const string & + string_view + template +[[nodiscard]] +constexpr inline basic_string<_CharT, _Traits, _Alloc> Redundant 'inline's +operator+(const basic_string<_CharT, _Traits, _Alloc>&