Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-30 Thread Tom Tromey
>> I don't think this comment is applicable. >> The libstdc++ pretty-printers use gdb.Value.lazy_string, not the >> built-in Python types. Samuel> Hmm, doesn't that just make it a timebomb -- a value that will Samuel> explode if, at some point in the future, someone tries to treat Samuel> it as a

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-25 Thread Samuel Bronson
Tom Tromey writes: >> "Samuel" == Samuel Bronson writes: > > Samuel> +# FIXME: The handling of e.g. std::basic_string (at least on char) > Samuel> +# probably needs updating to work with Python 3's new string rules. > Samuel> +# > Samuel> +# In particular, Python 3 has a separate type (calle

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-21 Thread Tom Tromey
> "Samuel" == Samuel Bronson writes: Samuel> +# FIXME: The handling of e.g. std::basic_string (at least on char) Samuel> +# probably needs updating to work with Python 3's new string rules. Samuel> +# Samuel> +# In particular, Python 3 has a separate type (called byte) for Samuel> +# bytestri

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: PR libstdc++/58962 * python/libstdcxx/v6/printers.py: Port to Python 2+3 (imap): New compat function. (izip): Likewise. (Iterator): New mixin to allow writing iterators in Python 3 style regardl