Re: [PATCH v3 3/3] AArch64: Diagnose OpenMP offloading when SVE types involved.

2025-03-17 Thread Tejas Belagod
On 3/7/25 5:33 PM, Jakub Jelinek wrote: On Fri, Mar 07, 2025 at 11:49:37AM +, Richard Sandiford wrote: +case TCTX_OMP_DEVICE_ADDR: + if (!silent_p) + error_at (loc, "SVE type %qT not allowed in target device clauses", type); Is the final error message accurate? This TCTX v

Re: [PATCH v3 3/3] AArch64: Diagnose OpenMP offloading when SVE types involved.

2025-03-07 Thread Jakub Jelinek
On Fri, Mar 07, 2025 at 11:49:37AM +, Richard Sandiford wrote: > > +case TCTX_OMP_DEVICE_ADDR: > > + if (!silent_p) > > + error_at (loc, "SVE type %qT not allowed in target device clauses", > > type); > > Is the final error message accurate? This TCTX value is used for clauses > l

Re: [PATCH v3 3/3] AArch64: Diagnose OpenMP offloading when SVE types involved.

2025-03-07 Thread Richard Sandiford
Tejas Belagod writes: > The target clause in OpenMP is used to offload loop kernels to accelarator > peripeherals. target's 'map' clause is used to move data from and to the > accelarator. When the data is SVE type, it may not be suitable because of > various reasons i.e. the two SVE targets may