Re: [PATCH v3 0/5] Implement mdspan.

2025-07-07 Thread Jonathan Wakely
On Fri, 4 Jul 2025 at 09:32, Luc Grosheintz wrote: > > This patch series replaces: > https://gcc.gnu.org/pipermail/libstdc++/2025-June/062207.html > > Addresses the review comments and improves commit messages. Most notably > the unnecessary patch to "strength" exception guarantees has been > remo

Re: [PATCH v3 0/5] Implement mdspan.

2025-07-07 Thread Luc Grosheintz
On 7/7/25 11:01, Tomasz Kaminski wrote: Hi, The patches look good to me, the only real comment is about using header guard, that I plan to do locally. I am testing on full test suite now, and will merge them pending the approval from Jonathan. From the patch that will set __cpp_lib_mdspan,

Re: [PATCH v3 0/5] Implement mdspan.

2025-07-07 Thread Tomasz Kaminski
Hi, The patches look good to me, the only real comment is about using header guard, that I plan to do locally. I am testing on full test suite now, and will merge them pending the approval from Jonathan. >From the patch that will set __cpp_lib_mdspan, do you want to create it? I can also prepare

Re: [PATCH v3 0/5] Implement mdspan.

2025-07-04 Thread Luc Grosheintz
Additionally, I think we can set __cpp_lib_mdspan. On 7/4/25 10:29, Luc Grosheintz wrote: This patch series replaces: https://gcc.gnu.org/pipermail/libstdc++/2025-June/062207.html Addresses the review comments and improves commit messages. Most notably the unnecessary patch to "strength" except