Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-10 Thread Zhouyi Zhou
Thanks Richard, nice adding, regression passed on my x86_64 GNU/Linux On Wed, Apr 10, 2013 at 5:22 PM, Richard Biener wrote: > On Tue, Apr 9, 2013 at 5:10 PM, Zhouyi Zhou wrote: >> Hi Richard, >> I do not have write access to GCC SVN repository, can you commit it for me? >> Thanks alot > > Commi

Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-10 Thread Richard Biener
On Tue, Apr 9, 2013 at 5:10 PM, Zhouyi Zhou wrote: > Hi Richard, > I do not have write access to GCC SVN repository, can you commit it for me? > Thanks alot Committed with adding { dg-require-weak "" } to the testcase. Richard. > Cheers > Zhouyi > > > On Tue, Apr 9, 2013 at 5:04 PM, Richard Bie

Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-09 Thread Zhouyi Zhou
Hi Richard, I do not have write access to GCC SVN repository, can you commit it for me? Thanks alot Cheers On Tue, Apr 9, 2013 at 5:04 PM, Richard Biener wrote: > > On Tue, Apr 9, 2013 at 5:40 AM, Zhouyi Zhou wrote: > > On Mon, Apr 8, 2013 at 5:48 PM, Richard Biener > > wrote: > >>Can you t

Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-09 Thread Richard Biener
On Tue, Apr 9, 2013 at 5:40 AM, Zhouyi Zhou wrote: > On Mon, Apr 8, 2013 at 5:48 PM, Richard Biener > wrote: >>Can you trigger this message to show up with -Winline before/after the patch? >>Can you please add a testcase then? > Thanks Richard for reviewing, from my point of view about gcc and m

Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-08 Thread Zhouyi Zhou
On Mon, Apr 8, 2013 at 5:48 PM, Richard Biener wrote: >Can you trigger this message to show up with -Winline before/after the patch? >Can you please add a testcase then? Thanks Richard for reviewing, from my point of view about gcc and my invoking of gcc, -Winline only works on callees that be d

Re: [PATCH v3]IPA: fixing inline fail report caused by overwritable functions.

2013-04-08 Thread Richard Biener
On Mon, Apr 8, 2013 at 4:47 AM, Zhouyi Zhou wrote: > When inline failed because of callee is overwritable, gcc will not report it > in dump file (triggered by -fdump-tree-einline) as other not inlinable cases > do. This patch correct this. > > Regtested/bootstrapped on x86_64-linux. Can you trigg