Re: [PATCH v3] libcpp: add function to check XID properties

2024-01-04 Thread Arthur Cohen
Hi Joseph, Thanks for the review! On 12/18/23 20:00, Joseph Myers wrote: On Fri, 8 Sep 2023, Arthur Cohen wrote: + if (c < 0x80) + { +if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z')) + return CPP_XID_START | CPP_XID_CONTINUE; +if (('0' <= c && c <= '9') || c == '_') + return

Re: [PATCH v3] libcpp: add function to check XID properties

2023-12-18 Thread Joseph Myers
On Fri, 8 Sep 2023, Arthur Cohen wrote: > + if (c < 0x80) > + { > +if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z')) > + return CPP_XID_START | CPP_XID_CONTINUE; > +if (('0' <= c && c <= '9') || c == '_') > + return CPP_XID_CONTINUE; This may be an artifact of how the patch was ma

Re: [PATCH v3] libcpp: add function to check XID properties

2023-10-16 Thread Arthur Cohen
Ping? Best, Arthur On 9/8/23 16:59, Arthur Cohen wrote: From: Raiki Tamura Fixed to include the enum's name which I had forgotten to commit. Thanks This commit adds a new function intended for checking the XID properties of a possibly unicode character, as well as the accompanying en