Re: [PATCH v3,rs6000] Add built-in function support for Power9 byte instructions

2016-12-13 Thread Sandra Loosemore
On 12/12/2016 05:40 PM, Kelvin Nilsen wrote: @@ -15105,6 +15109,24 @@ If all of the enabled test conditions are false, t The @code{scalar_test_neg} built-in functions return a non-zero value if their @code{source} argument holds a negative value. +The @code{__builtin_byte_in_set} function r

Re: [PATCH v3,rs6000] Add built-in function support for Power9 byte instructions

2016-12-13 Thread Segher Boessenkool
On Tue, Dec 13, 2016 at 05:25:52PM -0700, Kelvin Nilsen wrote: > Regarding the two test cases that are missing the scan-assembler > directive (byte-in-set-1.c and byte-in-set-2.c), those tests are both > expected to fail. They are checking that the compiler rejects those > programs with appropriat

Re: [PATCH v3,rs6000] Add built-in function support for Power9 byte instructions

2016-12-13 Thread Kelvin Nilsen
Thanks for your quick feedback. I'll update the comments regarding possible future enhancement to support QImode for operands[1] as well. Regarding the two test cases that are missing the scan-assembler directive (byte-in-set-1.c and byte-in-set-2.c), those tests are both expected to fail. They

Re: [PATCH v3,rs6000] Add built-in function support for Power9 byte instructions

2016-12-13 Thread Segher Boessenkool
Hi Kelvin, On Mon, Dec 12, 2016 at 05:40:05PM -0700, Kelvin Nilsen wrote: > The patch has been bootstrapped and tested on > powerpc64le-unknown-linux and powerpc-unknown-linux (big-endian, with > both -m32 and -m64 target options) with no regressions. > > Is this ok for the trunk? Yes it is, muc