Re: [PATCH v20 01/40] c++: Sort built-in traits alphabetically

2023-10-16 Thread Ken Matsui
On Mon, Oct 16, 2023 at 2:12 PM Patrick Palka wrote: > > On Mon, 16 Oct 2023, Ken Matsui wrote: > > > On Mon, Oct 16, 2023 at 8:17 AM Patrick Palka wrote: > > > > > > On Sun, 15 Oct 2023, Ken Matsui wrote: > > > > > > > This patch sorts built-in traits alphabetically for better code > > > > reada

Re: [PATCH v20 01/40] c++: Sort built-in traits alphabetically

2023-10-16 Thread Patrick Palka
On Mon, 16 Oct 2023, Ken Matsui wrote: > On Mon, Oct 16, 2023 at 8:17 AM Patrick Palka wrote: > > > > On Sun, 15 Oct 2023, Ken Matsui wrote: > > > > > This patch sorts built-in traits alphabetically for better code > > > readability. > > > > Hmm, I'm not sure if we still want/need this change wit

Re: [PATCH v20 01/40] c++: Sort built-in traits alphabetically

2023-10-16 Thread Ken Matsui
On Mon, Oct 16, 2023 at 8:17 AM Patrick Palka wrote: > > On Sun, 15 Oct 2023, Ken Matsui wrote: > > > This patch sorts built-in traits alphabetically for better code > > readability. > > Hmm, I'm not sure if we still want/need this change with this current > approach. IIUC gperf would sort the tr

Re: [PATCH v20 01/40] c++: Sort built-in traits alphabetically

2023-10-16 Thread Patrick Palka
On Sun, 15 Oct 2023, Ken Matsui wrote: > This patch sorts built-in traits alphabetically for better code > readability. Hmm, I'm not sure if we still want/need this change with this current approach. IIUC gperf would sort the trait names when generating the hash table code, and so we wanted a mo