Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-06 Thread Tomasz Kaminski
On Thu, Jul 3, 2025 at 4:14 PM Luc Grosheintz wrote: > Thank you for the nice review! I've locally implemented everything and > I'll send a v3 later today or tomorrow; after squashing the commits > correctly; and retesting everything. > > Meanwhile a couple of comments below. > > On 7/1/25 16:42,

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-03 Thread Luc Grosheintz
Thank you for the nice review! I've locally implemented everything and I'll send a v3 later today or tomorrow; after squashing the commits correctly; and retesting everything. Meanwhile a couple of comments below. On 7/1/25 16:42, Tomasz Kaminski wrote: On Fri, Jun 27, 2025 at 11:37 AM Luc Gros

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-01 Thread Tomasz Kaminski
On Fri, Jun 27, 2025 at 11:37 AM Luc Grosheintz wrote: > Implements the class mdspan as described in N4950, i.e. without P3029. > It also adds tests for mdspan. > > libstdc++-v3/ChangeLog: > > * include/std/mdspan (mdspan): New class. > * src/c++23/std.cc.in: Add std::mdspan. >

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-01 Thread Tomasz Kaminski
On Tue, Jul 1, 2025 at 3:44 PM Luc Grosheintz wrote: > > > On 7/1/25 12:44, Tomasz Kaminski wrote: > > Few initial comments. I will do a full-review with checks against wording > > later today or tomorrow. > > > > On Fri, Jun 27, 2025 at 11:37 AM Luc Grosheintz < > luc.groshei...@gmail.com> > > w

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-01 Thread Luc Grosheintz
On 7/1/25 12:44, Tomasz Kaminski wrote: Few initial comments. I will do a full-review with checks against wording later today or tomorrow. On Fri, Jun 27, 2025 at 11:37 AM Luc Grosheintz wrote: Implements the class mdspan as described in N4950, i.e. without P3029. It also adds tests for md

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-01 Thread Tomasz Kaminski
Few initial comments. I will do a full-review with checks against wording later today or tomorrow. On Fri, Jun 27, 2025 at 11:37 AM Luc Grosheintz wrote: > Implements the class mdspan as described in N4950, i.e. without P3029. > It also adds tests for mdspan. > > libstdc++-v3/ChangeLog: > >