Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

On Wed, May 15, 2019 at 5:51 PM Kewen.Lin wrote: > > on 2019/5/15 下午4:50, Bin.Cheng wrote: > > On Wed, May 15, 2019 at 4:38 PM Kewen.Lin wrote: > >> > >> on 2019/5/15 上午10:11, Kewen.Lin wrote: > >>> > >>> on 2019/5/14 下午3:18, Richard Biener wrote: > Hum. The function is somewhat of a hack,

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

on 2019/5/15 下午4:50, Bin.Cheng wrote: > On Wed, May 15, 2019 at 4:38 PM Kewen.Lin wrote: >> >> on 2019/5/15 上午10:11, Kewen.Lin wrote: >>> >>> on 2019/5/14 下午3:18, Richard Biener wrote: Hum. The function is somewhat of a hack, trying to produce "reasonable" DECL_RTL, exposing it in expr.

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

On Wed, 15 May 2019, Bin.Cheng wrote: > On Wed, May 15, 2019 at 4:38 PM Kewen.Lin wrote: > > > > on 2019/5/15 上午10:11, Kewen.Lin wrote: > > > > > > on 2019/5/14 下午3:18, Richard Biener wrote: > > >> Hum. The function is somewhat of a hack, trying to produce > > >> "reasonable" DECL_RTL, exposing

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

On Wed, May 15, 2019 at 4:38 PM Kewen.Lin wrote: > > on 2019/5/15 上午10:11, Kewen.Lin wrote: > > > > on 2019/5/14 下午3:18, Richard Biener wrote: > >> Hum. The function is somewhat of a hack, trying to produce > >> "reasonable" DECL_RTL, exposing it in expr.[ch] with this > >> name is eventually mis

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

On Wed, 15 May 2019, Kewen.Lin wrote: > > on 2019/5/14 下午3:18, Richard Biener wrote: > > Hum. The function is somewhat of a hack, trying to produce > > "reasonable" DECL_RTL, exposing it in expr.[ch] with this > > name is eventually misleading. Also you fail to "outline" > > the most important

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

on 2019/5/15 上午10:11, Kewen.Lin wrote: > > on 2019/5/14 下午3:18, Richard Biener wrote: >> Hum. The function is somewhat of a hack, trying to produce >> "reasonable" DECL_RTL, exposing it in expr.[ch] with this >> name is eventually misleading. Also you fail to "outline" >> the most important part

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

on 2019/5/14 下午3:18, Richard Biener wrote: > Hum. The function is somewhat of a hack, trying to produce > "reasonable" DECL_RTL, exposing it in expr.[ch] with this > name is eventually misleading. Also you fail to "outline" > the most important part: > > FOR_EACH_VEC_ELT (decl_rtl_to_reset,

Re: [PATCH v2 1/3] Move prepare_decl_rtl to expr.[ch] as extern

On Tue, May 14, 2019 at 5:09 AM wrote: > > From: Kewen Lin > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-04/msg00912.html > > This is a NFC (no functional change) patch. Ivopts has > some codes to expand gimple to RTL seq, but before call > expanding, we should call a prep