Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-22 Thread Jonathan Wakely
On Mon, 16 Sept 2024 at 13:53, Giuseppe D'Angelo wrote: > > Hi Jonathan, > > Thank you for picking up (the pieces of) my patch. I've pushed it to trunk now. Thanks for implementing it. > On 15/09/2024 17:00, Jonathan Wakely wrote: > >> Oops, that seems wrong, it seems the correct definition in t

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-16 Thread Giuseppe D'Angelo
Hi Jonathan, Thank you for picking up (the pieces of) my patch. On 15/09/2024 17:00, Jonathan Wakely wrote: Oops, that seems wrong, it seems the correct definition in terms of indirect_value_t should be remove_cvref_t>> as mentioned in P2248R8/5.9.1. That predates the note in p2609r3, bec

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-15 Thread Jonathan Wakely
On Fri, 13 Sept 2024 at 18:36, Patrick Palka wrote: > > On Fri, 13 Sep 2024, Patrick Palka wrote: > > > > Ah, we very recently implemented P2609R3 which has the following note > > about projected_value_t: https://wg21.link/p2609r3#proposal > > > > Do we want to honor this note here and define proj

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-15 Thread Jonathan Wakely
On Sun, 15 Sept 2024 at 15:53, Jonathan Wakely wrote: > > On Fri, 13 Sept 2024 at 18:14, Patrick Palka wrote: > > > > On Fri, 13 Sep 2024, Jonathan Wakely wrote: > > > > > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > > >

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-15 Thread Jonathan Wakely
On Fri, 13 Sept 2024 at 18:14, Patrick Palka wrote: > > On Fri, 13 Sep 2024, Jonathan Wakely wrote: > > > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > > wrote: > > > > > > > > Hello, > > > > > > > > as usual thank you for the

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-13 Thread Patrick Palka
On Fri, 13 Sep 2024, Patrick Palka wrote: > On Fri, 13 Sep 2024, Patrick Palka wrote: > > > On Fri, 13 Sep 2024, Jonathan Wakely wrote: > > > > > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > > > wrote: > > > > > > > > >

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-13 Thread Patrick Palka
On Fri, 13 Sep 2024, Patrick Palka wrote: > On Fri, 13 Sep 2024, Jonathan Wakely wrote: > > > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > > wrote: > > > > > > > > Hello, > > > > > > > > as usual thank you for the review. V2

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-13 Thread Patrick Palka
On Fri, 13 Sep 2024, Jonathan Wakely wrote: > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > wrote: > > > > > > Hello, > > > > > > as usual thank you for the review. V2 is attached. > > > > > > On 02/08/2024 14:38, Jonathan Wakely w

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-13 Thread Jonathan Wakely
On Fri, 13 Sept 2024 at 11:26, Jonathan Wakely wrote: > > On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > > wrote: > > > > > > Hello, > > > > > > as usual thank you for the review. V2 is attached. > > > > > > On 02/08/2024 14:38, Jonat

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-09-13 Thread Jonathan Wakely
On Sat, 3 Aug 2024 at 00:10, Jonathan Wakely wrote: > > On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo > wrote: > > > > Hello, > > > > as usual thank you for the review. V2 is attached. > > > > On 02/08/2024 14:38, Jonathan Wakely wrote: > > > On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote:

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo wrote: > > Hello, > > as usual thank you for the review. V2 is attached. > > On 02/08/2024 14:38, Jonathan Wakely wrote: > > On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote: > >> > >> On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: > >>> > >

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Giuseppe D'Angelo
Hello, as usual thank you for the review. V2 is attached. On 02/08/2024 14:38, Jonathan Wakely wrote: On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote: On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: Hello, The attached patch adds support for P2248R8 + P3217R0 (Enabling list-initi