Re: [PATCH v2] ipa-cp: Fix PGO regression caused by r278808

2020-01-02 Thread Jan Hubicka
> v2 Changes: > 1. Enable proportion orig_sum to the new nodes for self recursive node: >new_sum = (orig_sum + new_sum) \ >* self_recursive_probability * (1 / param_ipa_cp_max_recursive_depth). > 2. Add value range for param_ipa_cp_max_recursive_depth. > > The performance of exchange2 buil

Re: [PATCH v2] ipa-cp: Fix PGO regression caused by r278808

2019-12-31 Thread Feng Xue OS
esday, December 31, 2019 3:43 PM To: Feng Xue OS; Jan Hubicka; Martin Jambor Cc: Martin Liška; gcc-patches@gcc.gnu.org; seg...@kernel.crashing.org; wschm...@linux.ibm.com; guoji...@linux.ibm.com; li...@gcc.gnu.org Subject: Re: [PATCH v2] ipa-cp: Fix PGO regression caused by r278808 On 2019/12/31 14:43,

Re: [PATCH v2] ipa-cp: Fix PGO regression caused by r278808

2019-12-30 Thread luoxhu
On 2019/12/31 14:43, Feng Xue OS wrote: One comment: it's better to allow zero value for param_ipa_cp_max_recursive_depth, this can be used to disable recursive cloning. Thanks, "1" means no recursive cloning but only constant propagation from caller to callee in your code? ipa-cp.c, line 2

Re: [PATCH v2] ipa-cp: Fix PGO regression caused by r278808

2019-12-30 Thread Feng Xue OS
One comment: it's better to allow zero value for param_ipa_cp_max_recursive_depth, this can be used to disable recursive cloning. Feng From: luoxhu Sent: Monday, December 30, 2019 4:11 PM To: Jan Hubicka; Martin Jambor Cc: Martin Liška; gcc-patches@gcc.gn