Re: [PATCH v2] c++, coroutines: Improve diagnostics for awaiter/promise.

2025-06-14 Thread Iain Sandoe
> On 11 Jun 2025, at 17:51, Jason Merrill wrote: > > On 6/9/25 3:49 PM, Iain Sandoe wrote: >> Hi Jason, + error_at (loc, "%sawaitable type %qT is not a structure", + extra, o_type); >>> Generally identifiers should be incorporated with %qs, and relying on the >>> %s to

Re: [PATCH v2] c++, coroutines: Improve diagnostics for awaiter/promise.

2025-06-11 Thread Jason Merrill
On 6/9/25 3:49 PM, Iain Sandoe wrote: Hi Jason, + error_at (loc, "%sawaitable type %qT is not a structure", + extra, o_type); Generally identifiers should be incorporated with %qs, and relying on the %s to provide a space doesn't seem very i8n-friendly. Better, I think,