Re: [PATCH v2] alpha: Add -mlra option

2024-10-16 Thread John Paul Adrian Glaubitz
On Wed, 2024-10-16 at 09:39 +0200, Richard Biener wrote: > > Disabling M2 is enough to fix this. > > For practical purposes all reload->LRA conversions should focus on C > and C++. Everything > else is optional and not required to keep a port live (I'd argue it's > wasting cycles to look > at any

Re: [PATCH v2] alpha: Add -mlra option

2024-10-16 Thread Richard Biener
On Wed, Oct 16, 2024 at 4:40 AM John Paul Adrian Glaubitz wrote: > > On Tue, 2024-10-15 at 16:18 +0200, John Paul Adrian Glaubitz wrote: > > On Tue, 2024-10-15 at 07:56 -0600, Jeff Law wrote: > > > Also note if we think it's basically working I can flip my tester to > > > default to LRA. It boots

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread John Paul Adrian Glaubitz
On Tue, 2024-10-15 at 16:18 +0200, John Paul Adrian Glaubitz wrote: > On Tue, 2024-10-15 at 07:56 -0600, Jeff Law wrote: > > Also note if we think it's basically working I can flip my tester to > > default to LRA. It bootstraps and regtests alpha once a week via qemu. > > > > I think it's testin

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread John Paul Adrian Glaubitz
On Tue, 2024-10-15 at 07:56 -0600, Jeff Law wrote: > Also note if we think it's basically working I can flip my tester to > default to LRA. It bootstraps and regtests alpha once a week via qemu. > > I think it's testing the baseline configuration, so presumably non-BWX > variants. That can pro

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Jeff Law
On 10/15/24 6:47 AM, Richard Biener wrote: On Tue, Oct 15, 2024 at 2:41 PM John Paul Adrian Glaubitz wrote: Hi Maciej, On Tue, 2024-10-15 at 13:36 +0100, Maciej W. Rozycki wrote: IMO, we should simply deprecate non-BWX targets. If reload is going away, then there is no way for non-BWX tar

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Maciej W. Rozycki
On Tue, 15 Oct 2024, Richard Biener wrote: > > FWIW, it *seems* that LRA seems to just work with EV56 as the baseline and > > the > > following replacements in the code: > > > > s/reload_in_progress/reload_in_progress || lra_in_progress/g > > If you can provide -mlra vs. -mno-lra testsui

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Oleg Endo
On Tue, 2024-10-15 at 15:06 +0200, John Paul Adrian Glaubitz wrote: > On Tue, 2024-10-15 at 14:47 +0200, Richard Biener wrote: > > If you can provide -mlra vs. -mno-lra testsuite results as well that > > would be interesting. > > OK, I'll try to provide these. > > > Does "just work" mean you can

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread John Paul Adrian Glaubitz
Hi Richard, On Tue, 2024-10-15 at 14:47 +0200, Richard Biener wrote: > If you can provide -mlra vs. -mno-lra testsuite results as well that > would be interesting. OK, I'll try to provide these. > Does "just work" mean you can build the compiler and its target > libraries? I'm performing a full

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Richard Biener
On Tue, Oct 15, 2024 at 2:41 PM John Paul Adrian Glaubitz wrote: > > Hi Maciej, > > On Tue, 2024-10-15 at 13:36 +0100, Maciej W. Rozycki wrote: > > > IMO, we should simply deprecate non-BWX targets. If reload is going > > > away, then there is no way for non-BWX targets to access reload > > > inte

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread John Paul Adrian Glaubitz
Hi Maciej, On Tue, 2024-10-15 at 13:36 +0100, Maciej W. Rozycki wrote: > > IMO, we should simply deprecate non-BWX targets. If reload is going > > away, then there is no way for non-BWX targets to access reload > > internals they require for compilation. As mentioned in the PR, > > non-BWX targets

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Maciej W. Rozycki
On Tue, 15 Oct 2024, Uros Bizjak wrote: > > PR target/66207 > > * config/alpha/alpha.opt (mlra): New target option. > > * config/alpha/alpha.cc (alpha_use_lra_p): New function. > > (TARGET_LRA_P): Use it. > > * config/alpha/alpha.opt.urls: Regenerate. > > IMO, we should simply deprecate non-BWX t

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread John Paul Adrian Glaubitz
CC'ing Maciej who has also worked on Alpha Hi Uros, On Tue, 2024-10-15 at 12:29 +0200, Uros Bizjak wrote: > On Tue, Oct 15, 2024 at 11:09 AM John Paul Adrian Glaubitz > wrote: > > > > PR target/66207 > > * config/alpha/alpha.opt (mlra): New target option. > > * config/alpha/alpha.cc (alpha_use_

Re: [PATCH v2] alpha: Add -mlra option

2024-10-15 Thread Uros Bizjak
On Tue, Oct 15, 2024 at 11:09 AM John Paul Adrian Glaubitz wrote: > > PR target/66207 > * config/alpha/alpha.opt (mlra): New target option. > * config/alpha/alpha.cc (alpha_use_lra_p): New function. > (TARGET_LRA_P): Use it. > * config/alpha/alpha.opt.urls: Regenerate. IMO, we should simply depre