Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
No problem! I'll send a follow up with the requested changes. Thanks for the input! Manos. On Thu, Sep 28, 2023 at 4:42 PM Richard Sandiford wrote: > Manos Anagnostakis writes: > > Hey Richard, > > > > Thanks for taking the time to review this, but it has been commited since > > yesterday af

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Manos Anagnostakis writes: > Hey Richard, > > Thanks for taking the time to review this, but it has been commited since > yesterday after getting reviewed by Kyrill and Tamar. > > Discussions: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html > https://gcc.gnu.org/pipermail/gc

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Sure, I will attend to this. Manos. On Thu, Sep 28, 2023 at 4:37 PM Philipp Tomsich wrote: > Manos, > > Please submit a follow-on patch implementing the requested > improvements of the code structure (as this reduces the maintenance > burden). > > Thanks, > Philipp. > > > On Thu, 28 Sept 2023 a

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Philipp Tomsich
Manos, Please submit a follow-on patch implementing the requested improvements of the code structure (as this reduces the maintenance burden). Thanks, Philipp. On Thu, 28 Sept 2023 at 15:33, Manos Anagnostakis wrote: > > Hey Richard, > > Thanks for taking the time to review this, but it has be

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Manos Anagnostakis
Hey Richard, Thanks for taking the time to review this, but it has been commited since yesterday after getting reviewed by Kyrill and Tamar. Discussions: https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631285.html https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631300.html https

Re: [PATCH v2] aarch64: Fine-grained ldp and stp policies with test-cases.

2023-09-28 Thread Richard Sandiford
Thanks for the patch and sorry for the slow review. Manos Anagnostakis writes: > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > to provide the requested behaviour for handling ldp and stp: > > /* Allow the tuning structure to disable LDP instruction formation >