Re: [PATCH v2] Fix PR64242

2019-05-31 Thread Jeff Law
On 5/28/19 11:26 AM, Wilco Dijkstra wrote: > Improve the fix for PR64242. Various optimizations can change a memory > reference > into a frame access. Given there are multiple virtual frame pointers which > may > be replaced by multiple hard frame pointers, there are no checks for writes > to

Re: [PATCH v2] Fix PR64242

2019-01-10 Thread Wilco Dijkstra
Hi Jakub, Any other comments? I'd like to finish this rather than leaving it in its current half-done state. Wilco   Hi, Jakub Jelinek wrote: On Fri, Dec 07, 2018 at 04:19:22PM +, Wilco Dijkstra wrote: >> The test case doesn't need an aligned object to fail, so why did you add it? > > It

Re: [PATCH v2] Fix PR64242

2018-12-07 Thread Wilco Dijkstra
Hi, Jakub Jelinek wrote: On Fri, Dec 07, 2018 at 04:19:22PM +, Wilco Dijkstra wrote: >> The test case doesn't need an aligned object to fail, so why did you add it? > > It needed it on i686, because otherwise it happened to see the value it > wanted in the caller's stack frame. Right, so I f

Re: [PATCH v2] Fix PR64242

2018-12-07 Thread Jakub Jelinek
On Fri, Dec 07, 2018 at 04:19:22PM +, Wilco Dijkstra wrote: > Jakub Jelinek wrote: > > On Fri, Dec 07, 2018 at 02:52:48PM +, Wilco Dijkstra wrote: > >> -  struct __attribute__((aligned (32))) S { int a[4]; } s;  > >>   

Re: [PATCH v2] Fix PR64242

2018-12-07 Thread Wilco Dijkstra
Hi, Jakub Jelinek wrote: > On Fri, Dec 07, 2018 at 02:52:48PM +, Wilco Dijkstra wrote: >> -  struct __attribute__((aligned (32))) S { int a[4]; } s;    >>   >> -  bar (&s);  

Re: [PATCH v2] Fix PR64242

2018-12-07 Thread Jakub Jelinek
On Fri, Dec 07, 2018 at 02:52:48PM +, Wilco Dijkstra wrote: > - struct __attribute__((aligned (32))) S { int a[4]; } s; > > - bar (&s); >