Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2025-01-09 Thread Richard Sandiford
Wilco Dijkstra writes: > Hi Richard, > >> The patch below is what I meant.  It passes bootstrap & regression-test >> on aarch64-linux-gnu (and so produces the same results for the tests >> that you changed).  Do you see any problems with this version? >> If not, I think we should go with it. > > T

Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2025-01-09 Thread Wilco Dijkstra
Hi Richard, > The patch below is what I meant.  It passes bootstrap & regression-test > on aarch64-linux-gnu (and so produces the same results for the tests > that you changed).  Do you see any problems with this version? > If not, I think we should go with it. Thanks for the detailed example - u

Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2025-01-08 Thread Richard Sandiford
Wilco Dijkstra writes: > Hi Richard, > >> ...I still think we should avoid testing can_create_pseudo_p. >> Does it work with the last part replaced by: >> >>  if (!DECIMAL_FLOAT_MODE_P (mode)) >>    { >>  if (aarch64_can_const_movi_rtx_p (src, mode) >>  || aarch64_float_const_represent

Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2024-11-13 Thread Wilco Dijkstra
Hi Richard, > ...I still think we should avoid testing can_create_pseudo_p. > Does it work with the last part replaced by: > >  if (!DECIMAL_FLOAT_MODE_P (mode)) >    { >  if (aarch64_can_const_movi_rtx_p (src, mode) >  || aarch64_float_const_representable_p (src) >  || aarch64

Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2024-11-12 Thread Richard Sandiford
Wilco Dijkstra writes: > Hi Richard, > >> The idea was that, if we did the split during expand, the movsf/df >> define_insns would then only accept the immediates that their >> constraints can handle. > > Right, always disallowing these immediates works fine too (it seems > reload doesn't require

Re: [PATCH v2] AArch64: Block combine_and_move from creating FP literal loads

2024-11-12 Thread Wilco Dijkstra
Hi Richard, > The idea was that, if we did the split during expand, the movsf/df > define_insns would then only accept the immediates that their > constraints can handle. Right, always disallowing these immediates works fine too (it seems reload doesn't require all immediates to be valid), and th