Committed, thanks Kito.
Pan
From: Kito Cheng
Sent: Monday, August 14, 2023 11:02 PM
To: Li, Pan2
Cc: Wang, Yanzhang ; gcc-patches
; 钟居哲
Subject: Re: [PATCH v1] RISC-V: Support RVV VFREC7 rounding mode intrinsic API
Checked with doc and llvm implementation, LGTM
Checked with doc and llvm implementation, LGTM
: Support RVV VFREC7 rounding mode intrinsic API
> +template
You don't need a template class here since it can only be UNSPEC_VFREC7.
> +class vfrec7_frm : public function_base
> +{
> +public:
> + bool has_rounding_mode_operand_p () const override { return true; }
> +
> + rtx
> +template
You don't need a template class here since it can only be UNSPEC_VFREC7.
> +class vfrec7_frm : public function_base
> +{
> +public:
> + bool has_rounding_mode_operand_p () const override { return true; }
> +
> + rtx expand (function_expander &e) const override
> + {
> +return e
I defer this patch's review to kito since I am not sure whether vfrec7 needs
rounding mode.
juzhe.zh...@rivai.ai
From: pan2.li
Date: 2023-08-14 20:49
To: gcc-patches
CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng
Subject: [PATCH v1] RISC-V: Support RVV VFREC7 rounding mode intrinsic API