RE: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-28 Thread Li, Pan2 via Gcc-patches
Committed, thanks Kito and Juzhe. Pan -Original Message- From: Kito Cheng Sent: Thursday, June 29, 2023 10:35 AM To: Li, Pan2 Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, Yanzhang ; jeffreyalaw Subject: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

RE: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-28 Thread Li, Pan2 via Gcc-patches
Sent: Thursday, June 29, 2023 10:44 AM To: Kito.cheng ; Li, Pan2 Cc: gcc-patches ; Wang, Yanzhang ; jeffreyalaw Subject: Re: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add Hi, Pan. I think the last step is to support dynamic mode switching which may need to

Re: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-28 Thread juzhe.zh...@rivai.ai
6-29 10:35 To: Li, Pan2 CC: juzhe.zh...@rivai.ai; gcc-patches; Wang, Yanzhang; jeffreyalaw Subject: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add LGTM, thanks! On Tue, Jun 27, 2023 at 3:02 PM Li, Pan2 wrote: > > Ack, thanks Juzhe. > > > >

Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-28 Thread Kito Cheng via Gcc-patches
effreyalaw > Subject: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV > floating-point add > > > > LGTM. > > You can go ahead to implement rounding mode of floating-point by > mode-switching: > > > > Suggest you implement rounding mode for floatin

RE: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-27 Thread Li, Pan2 via Gcc-patches
Ack, thanks Juzhe. Pan From: juzhe.zh...@rivai.ai Sent: Tuesday, June 27, 2023 3:00 PM To: Li, Pan2 ; gcc-patches Cc: Kito.cheng ; Li, Pan2 ; Wang, Yanzhang ; jeffreyalaw Subject: Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add LGTM. You can go ahead to

Re: [PATCH v1] RISC-V: Allow rounding mode control for RVV floating-point add

2023-06-26 Thread juzhe.zh...@rivai.ai
LGTM. You can go ahead to implement rounding mode of floating-point by mode-switching: Suggest you implement rounding mode for floating-poing as follows: 1st step: Implement mode-switching for floating-point rounding mode except DYNAMIC which should be totally same as fixed-point. 2nd step: Sup