Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics (try 2)

2014-12-11 Thread Tobias Burnus
Dodji Seketeli wrote: Manuel López-Ibáñez writes: New version using XNEW. Bootstrapped & tested on x86_64-linux-gnu. OK? The diagnostics infrastructure changes are OK for me. Thanks! And the Fortran part was already approved before. (Otherwise, take this as another rubber stamp.) Thanks

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics (try 2)

2014-12-11 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > New version using XNEW. Bootstrapped & tested on x86_64-linux-gnu. > > OK? The diagnostics infrastructure changes are OK for me. Thanks! Cheers, -- Dodji

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-10 Thread Manuel López-Ibáñez
On 10 December 2014 at 13:54, Dodji Seketeli wrote: >> /* Report the number of warnings and errors that occurred to the caller. */ >> >> @@ -1525,11 +1625,14 @@ gfc_diagnostics_init (void) >> { >>diagnostic_starter (global_dc) = gfc_diagnostic_starter; >>diagnostic_finalizer (global_dc)

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-10 Thread Dodji Seketeli
Hello Manuel, Manuel López-Ibáñez writes: > New version of the patch. Tobias noticed several problems with the > previous version: > > * Due to the use of placement-new for the buffered output_buffers > pp_warning_buffer and pp_error_buffer, the pretty-printer destructor > may end up trying to f

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-07 Thread Tobias Burnus
Manuel López-Ibáñez wrote: OK, this is then the final patch. Bootstrapped and regression tested on x86_64-linux-gnu. OK to commit? void gfc_buffer_error (bool flag) { buffered_p = flag; - pp_warning_buffer.flush_p = !flag; + buffered_p = flag; } Now there are two "buffered_p" … Other