Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-10-01 Thread Evgeny Stupachenko
Similar patch is under discussion at another mail thread: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00025.html The main point is that each expand function called in order to number of expanded insns starting from 1. expand_vec_perm_palignr is expected to produce not more than 2 insns. palignr f

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 08:26:27AM +0200, Uros Bizjak wrote: > On Wed, Oct 1, 2014 at 12:13 AM, Evgeny Stupachenko > wrote: > > expand_vselect for some reason ignores the expander. > > Does it work with expanders? > > The comment talks about insn only: > > /* Construct (set target (vec_select op0

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 12:13 AM, Evgeny Stupachenko wrote: > expand_vselect for some reason ignores the expander. > Does it work with expanders? > The comment talks about insn only: > /* Construct (set target (vec_select op0 (parallel perm))) and >return true if that's a valid instruction in t

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Evgeny Stupachenko
expand_vselect for some reason ignores the expander. Does it work with expanders? The comment talks about insn only: /* Construct (set target (vec_select op0 (parallel perm))) and return true if that's a valid instruction in the active ISA. */ On Tue, Sep 30, 2014 at 10:21 PM, Uros Bizjak wro

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Evgeny Stupachenko
>What happens when shift == 16? We emit just gen_avx2_permv2ti. We don't need additional palignr. On Tue, Sep 30, 2014 at 9:06 PM, Uros Bizjak wrote: > On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko > wrote: > >> Patch resubmitted from >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg0140

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 8:08 PM, Uros Bizjak wrote: > On Tue, Sep 30, 2014 at 7:06 PM, Uros Bizjak wrote: >> On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko >> wrote: >> >>> Patch resubmitted from >>> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html >>> >>> The patch fix PR62128 an

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 7:06 PM, Uros Bizjak wrote: > On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko > wrote: > >> Patch resubmitted from >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html >> >> The patch fix PR62128 and "gcc.target/i386/pr52252-atom.c" in >> core-avx2 make check

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 10:03:05AM -0700, H.J. Lu wrote: > On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko > wrote: > > Hi, > > > > Patch resubmitted from > > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html > > > > The patch fix PR62128 and "gcc.target/i386/pr52252-atom.c" in > > c

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko wrote: > Patch resubmitted from > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html > > The patch fix PR62128 and "gcc.target/i386/pr52252-atom.c" in > core-avx2 make check. > The test in pr62128 is exactly TEST 22 from > gcc.dg/torture

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread H.J. Lu
On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko wrote: > Hi, > > Patch resubmitted from > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html > > The patch fix PR62128 and "gcc.target/i386/pr52252-atom.c" in > core-avx2 make check. > The test in pr62128 is exactly TEST 22 from > gcc.dg/