Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-05-07 Thread Indu Bhagat via Gcc-patches
On 4/29/21 11:17 PM, Richard Biener wrote: On Thu, 29 Apr 2021, Indu Bhagat wrote: Hello, On 4/29/21 5:10 AM, Richard Biener wrote: On Thu, 29 Apr 2021, Jose E. Marchesi wrote: This commit introduces support for generating CTF debugging information and BTF debugging information from GCC.

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-05-03 Thread Richard Biener
On Fri, 30 Apr 2021, David Faust wrote: > > On 4/30/21 9:11 AM, Jose E. Marchesi via Gcc-patches wrote: > > > >>> For a moment, for the sake of this question, if we establish that CTF/BTF > >>> generation always feeds off DWARF DIEs (so there is no need to access > >>> type/decl tree nodes), wha

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-04-30 Thread David Faust via Gcc-patches
On 4/30/21 9:11 AM, Jose E. Marchesi via Gcc-patches wrote: > >>> For a moment, for the sake of this question, if we establish that CTF/BTF >>> generation always feeds off DWARF DIEs (so there is no need to access >>> type/decl tree nodes), what will it take to keep LTO support while keeping >>>

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-04-30 Thread Jose E. Marchesi via Gcc-patches
>> For a moment, for the sake of this question, if we establish that CTF/BTF >> generation always feeds off DWARF DIEs (so there is no need to access >> type/decl tree nodes), what will it take to keep LTO support while keeping >> ctf_debug_finalize in dwarf2out_finish ? > > I don't think it's po

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-04-29 Thread Richard Biener
On Thu, 29 Apr 2021, Indu Bhagat wrote: > Hello, > > On 4/29/21 5:10 AM, Richard Biener wrote: > > On Thu, 29 Apr 2021, Jose E. Marchesi wrote: > > > >> This commit introduces support for generating CTF debugging > >> information and BTF debugging information from GCC. > > > > Comments inline.

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-04-29 Thread Indu Bhagat via Gcc-patches
On 4/29/21 1:02 PM, Indu Bhagat wrote: +{ +  dw_die_ref c; + +  if (!ctf_do_die (die)) +    return; + +  FOR_EACH_CHILD (die, c, ctf_do_die (c)); +} +   /* Perform any cleanups needed after the early debug generation pass has run.  */ @@ -32471,6 +32491,16 @@ dwarf2out_early_finish (const

Re: [PATCH V7 4/7] CTF/BTF debug formats

2021-04-29 Thread Indu Bhagat via Gcc-patches
Hello, On 4/29/21 5:10 AM, Richard Biener wrote: On Thu, 29 Apr 2021, Jose E. Marchesi wrote: This commit introduces support for generating CTF debugging information and BTF debugging information from GCC. Comments inline. Thanks for your reviews. My responses and questions inline at resp